Fix parallel running for multiple experiments (#34)

abrouter · Aug 1, 2024 · 1fc770b · 1fc770b
1 parent 8844926
commit 1fc770b
Showing 1 changed file with 4 additions and 10 deletions.
diff --git a/src/Services/ExperimentsParallelRun/ParallelRunner.php b/src/Services/ExperimentsParallelRun/ParallelRunner.php
@@ -16,11 +16,6 @@ class ParallelRunner
      */
     private $experimentBranchesCacheRepository;
 
-    /**
-     * @var ExperimentRunner
-     */
-    private $experimentRunner;
-
     /**
      * @var ParallelRunConfigAccessor
      */
@@ -35,13 +30,11 @@ class ParallelRunner
 
     public function __construct(
         ExperimentBranchesCacheRepository $experimentBranchesCacheRepository,
-        ExperimentRunner $experimentRunner,
         ParallelRunConfigAccessor $parallelRunConfig,
         Cacher $cacher,
         RelatedUserBranchDetector $relatedUserBranchDetector
     ) {
         $this->experimentBranchesCacheRepository = $experimentBranchesCacheRepository;
-        $this->experimentRunner = $experimentRunner;
         $this->parallelRunConfigAccessor = $parallelRunConfig;
         $this->cacher = $cacher;
         $this->relatedUsersBranchDetector = $relatedUserBranchDetector;
@@ -54,15 +47,16 @@ public function run(string $userSignature, string $experimentAlias): ExperimentR
             return $experimentRunResult;
         }
 
-        $runFunction = function () use ($experimentAlias, $userSignature) {
+        $experimentRunner = new ExperimentRunner();
+        $runFunction = function () use ($experimentAlias, $userSignature, $experimentRunner) {
             $branches = $this
                 ->experimentBranchesCacheRepository
                 ->getByExperimentAlias($experimentAlias);
 
             foreach ($branches->getExperimentBranches() as $branch) {
-                $this->experimentRunner->addSide($branch->getUid(), (float)$branch->getPercentage());
+                $experimentRunner->addSide($branch->getUid(), (float)$branch->getPercentage());
             }
-            $branch = $this->experimentRunner->roll();
+            $branch = $experimentRunner->roll();
 
             $task = new AddUserToBranchTask(
                 $experimentAlias,