v2: minor changes but breaking #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
switch from tinylib/msgp to github.com/vmihailenco/msgpack/v5 as it's more flexible and doesn't require codegen. Might be a bit slower since it uses reflection? Haven't tested performance. Use store arbitrary metadata as something which can be serialized and deserialized to and from the Sessions struct. Might unexport the Meta struct
Thought a lot about this change. Want to be able to support standard SQL backend database engines (BYO SQL database session plugins) and what I realized I want most from that is structured data in my sessions table. That structured data may be out of scope for the other KV stores: e.g. last active IP / location would not be as easily usable in a KV datastore. Between []bytes and the any type, there wasn't really a good option that didn't involve either using reflection or serialization. Therefore I decided it would be better to fallback to KV pairs. I will play around with this a bit to decide which format works better: a slice of kv pairs (probably more efficient) or a map (more naturally usable). I could (may still) make the underlying slice/map unexported to support swapping between them for ease-of-maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
switch from tinylib/msgp to github.com/vmihailenco/msgpack/v5 as it's more flexible and doesn't require codegen. Might be a bit slower since it uses reflection? Haven't tested performance.
Use store arbitrary metadata as something which can be serialized and deserialized to and from the Sessions struct. Might unexport the Meta struct. Almost went with generics, but found the serialization pattern to be more digestible.