Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle NoneType in VersionRange.from_string #115

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Handle NoneType in VersionRange.from_string #115

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b043035
Handle NoneType in VersionRange.from_string
keshav-space Aug 29, 2023
9e1b417
Address review comments
keshav-space Aug 30, 2023
30f41ae
Merge remote-tracking branch 'origin/main' into 113-fix-versionrange
keshav-space Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/univers/version_range.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,11 @@ def from_string(cls, vers, simplify=False, validate=False):
Return a VersionRange built from a ``vers`` version range spec string,
such as "vers:npm/1.2.3,>=2.0.0"
"""
if not vers or not isinstance(vers, str) or not vers.strip():
raise ValueError(
f"{vers!r} is not a valid argument, a valid ``vers`` string argument is required."
)

# Spaces are not significant and removed in a canonical form.
vers = remove_spaces(vers)

Expand Down