Refactor the BasePipeline, move out all Project related logic #1351 #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
tdruez
changed the title
|
@keshav-space could you have a look before the merge? |
tdruez
requested review from
keshav-space and
pombredanne
and removed request for
keshav-space and
pombredanne
keshav-space
approved these changes
Aug 8, 2024
| ### Install | ||
|
|
||
| ```bash | ||
| pip install aboutcode_pipeline |
There was a problem hiding this comment.
As per PEP8 https://peps.python.org/pep-0008/#package-and-module-names aboutcode-pipeline would be a much more Pythonic package name.
Actually, going by @pombredanne suggestion here #1332 (comment), we may want to name this package aboutcode.pipeline.
Suggested change
| pip install aboutcode_pipeline | |
| pip install aboutcode.pipeline |
There was a problem hiding this comment.
I initially went with aboutcode_pipeline in the README as the filenames of the flot build were aboutcode_pipeline-0.1.whl, even though the [project] name was set to "aboutcode.pipeline".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the BasePipeline to remove the scanpipe.Project logic and make it reusable without Project context.