Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update browsersync to fix npm vulnerabilities #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update browsersync to fix npm vulnerabilities #25

wants to merge 1 commit into from

Conversation

jegli
Copy link
Contributor

@jegli jegli commented Aug 12, 2020

Hi @abmaonline

Browsersync finally updated its dependencies which resolves the npm vulnerabilities. I have updated the dependency in my fork, built aemfed and used the version in our project. It works just like before. Feel free to test on your end as well.

Thanks again and have a nice evening.

@abmaonline
Copy link
Owner

Thanks! Since it needs node 8 now, I was already working on a local branch to upgrade all relevant packages to node 8. Good to now it is working fine on your project, since testing the Browsersync update would be most of the work (since aemfed is essentially an extension for it :P)!

I will try to finish the upgrade in the coming days and create a release candidate for it. Would be great if you could test that one for a while as well?

@jegli
Copy link
Contributor Author

jegli commented Aug 13, 2020

Oh, good point regarding node 8. 😅

I will be happy to test the new rc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants