Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-add "unnecessary" normalization to fix UTF-8 errors. #50

Merged
merged 3 commits into from
Aug 31, 2024

Conversation

UsernamesLame
Copy link
Contributor

I forgot to remove this line yesterday, I'm not sure why it's not causing any issues having it there referencing a nonexistent variable samples but it seems like normalization wasn't required based on transcription testing I've done so far.

@abdeladim-s
Copy link
Owner

Oh, I didn't notice yesterday, and I didn't run any tests.
Next time please run the tests in the test directory before committing!

As for this, I think normalization is important, without it sometimes I get utf-8 decode problems.
Please fix the code to arr /= np.iinfo(np.int16).max and commit it so I cam merge the fix asap.

Thanks!

@UsernamesLame
Copy link
Contributor Author

Sorry about that. Slipped my mind to do the tests. Thankfully it didn't seem to actually break anything. That's the craziest part.

@UsernamesLame
Copy link
Contributor Author

@abdeladim-s I re-added the normalization. I haven't had a chance to run the test suite. For now I'm relying on the CI pipeline to catch anything.

I re-added arr /= np.iinfo(np.int16).max

@UsernamesLame UsernamesLame changed the title Remove unnecessary audio normalization re-add "unnecessary" normalization to fix UTF-8 errors. Aug 31, 2024
@abdeladim-s
Copy link
Owner

It's okey, no worries!
I, indeed, need to include the tests in CI, for now I am just running them locally 😄

I'll merge this for now.
Thanks a lot!

@abdeladim-s abdeladim-s merged commit 8a759cc into abdeladim-s:main Aug 31, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants