Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/shared lib load #46

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Conversation

thewh1teagle
Copy link
Contributor

Resolve #43

Copy link
Owner

@abdeladim-s abdeladim-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, Looks great!
One last thing before merging, can you build a wheel and check if the lib folder is included as well ?

setup.py Show resolved Hide resolved
pywhispercpp/__init__.py Show resolved Hide resolved
@abdeladim-s abdeladim-s merged commit 3ee9803 into abdeladim-s:main Aug 29, 2024
8 of 11 checks passed
@abdeladim-s
Copy link
Owner

Thanks a lot for the time you put into this :)

@thewh1teagle
Copy link
Contributor Author

Thanks for the PR, Looks great! One last thing before merging, can you build a wheel and check if the lib folder is included as well ?

$ ls
pywhispercpp-1.2.0-cp312-cp312-win_amd64  pywhispercpp-1.2.0-cp312-cp312-win_amd64.whl

$ ls pywhispercpp-1.2.0-cp312-cp312-win_amd64/pywhispercpp/lib/
_pywhispercpp.cp312-win_amd64.pyd  ggml.dll  whisper.dll

@abdeladim-s
Copy link
Owner

Thanks for the PR, Looks great! One last thing before merging, can you build a wheel and check if the lib folder is included as well ?

$ ls
pywhispercpp-1.2.0-cp312-cp312-win_amd64  pywhispercpp-1.2.0-cp312-cp312-win_amd64.whl

$ ls pywhispercpp-1.2.0-cp312-cp312-win_amd64/pywhispercpp/lib/
_pywhispercpp.cp312-win_amd64.pyd  ggml.dll  whisper.dll

Looks perfect.
Thanks!

abdeladim-s added a commit that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install failed on Windows
2 participants