Optimisation of the balance/debt increase math #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyzia551
requested review from
The-3D,
miguelmtzinf,
stevenvaleri,
foodaka,
kartojal,
Zer0dot,
donosonaumczuk and
BenSparksCode
as code owners
amandaweston1306
approved these changes
Aug 23, 2022
miguelmtzinf
requested changes
Nov 3, 2022
| uint256 balanceIncrease = scaledBalance.rayMul(index) - | ||
| scaledBalance.rayMul(_userState[onBehalfOf].additionalData); | ||
|
|
||
| uint256 balanceIncrease = scaledBalance.rayMul(index - _userState[onBehalfOf].additionalData); |
There was a problem hiding this comment.
This approach is not exactly equivalent to the other because of math rounding and precision. We should stick to the original approach
| reserveCache.nextVariableBorrowIndex | ||
| // calculate the total variable debt increase after the moment of the last interaction | ||
| uint256 variableDebtIncrease = reserveCache.currScaledVariableDebt.rayMul( | ||
| reserveCache.nextVariableBorrowIndex - reserveCache.currVariableBorrowIndex |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes one operation in the balance/debt increase-related calculations. Also because of this opt it's no need to use
AccrueToTreasuryLocalVarson the_accrueToTreasuryfunction