Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join: feature dataset #35

Merged
merged 17 commits into from
Feb 14, 2024
Merged

Join: feature dataset #35

merged 17 commits into from
Feb 14, 2024

Conversation

JakobEliasWagner
Copy link
Collaborator

@JakobEliasWagner JakobEliasWagner commented Feb 13, 2024

Feature/Cleanup: New Dataset Interface

Description

This pull request introduces an update to the datat-set handling mechanism.
It aims to leverage PyTorch's Dataset handling features to improve model's performance, scalability, ease of use, and maintainability.

Solves #31

Which issue does this PR tackle?

  • Scalability of the data-handling system
  • Efficiency of the data-handling system
  • Ease of Use: Currently new features need to be manually added onto the set
  • Integration with PyTorch Ecosystem

How does it solve the problem?

How are the changes tested?

  • The previously implemented adjusted unit-tests run without error.

Checklist for Contributors

  • Scope: This PR tackles exactly one problem.
  • Conventions: The branch follows the feature/title-slug convention.
  • Conventions: The PR title follows the Bugfix: Title convention.
  • Coding style: The code passes all pre-commit hooks.
  • Documentation: All changes are well-documented.
  • Tests: New features are tested and all tests pass successfully.
  • Changelog: Updated CHANGELOG.md for new features or breaking changes.
  • Review: A suitable reviewer has been assigned.

Checklist for Reviewers:

  • The PR solves the issue it claims to solve and only this one.
  • Changes are tested sufficiently and all tests pass.
  • Documentation is complete and well-written.
  • Changelog has been updated, if necessary.

notebooks/basics.ipynb Outdated Show resolved Hide resolved
notebooks/basics.ipynb Outdated Show resolved Hide resolved
notebooks/basics.ipynb Outdated Show resolved Hide resolved
notebooks/basics.ipynb Outdated Show resolved Hide resolved
notebooks/basics.ipynb Outdated Show resolved Hide resolved
src/continuity/data/sine.py Outdated Show resolved Hide resolved
src/continuity/data/shape.py Outdated Show resolved Hide resolved
src/continuity/operators/deeponet.py Outdated Show resolved Hide resolved
notebooks/selfsupervised.ipynb Outdated Show resolved Hide resolved
notebooks/superresolution.ipynb Outdated Show resolved Hide resolved
@JakobEliasWagner
Copy link
Collaborator Author

@samuelburbulla added your suggested changes to the PR. Need some clarification on whether you think it is okay to use xi in basics.ipynb. Furthermore, I do not have access to the flame dataset.

@JakobEliasWagner JakobEliasWagner merged commit f7f371e into main Feb 14, 2024
8 checks passed
@JakobEliasWagner JakobEliasWagner deleted the join/feature-dataset branch February 14, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants