-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Join: feature dataset #35
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakobEliasWagner
force-pushed
the
join/feature-dataset
branch
from
February 13, 2024 10:04
b0b6141
to
07337b4
Compare
samuelburbulla
requested changes
Feb 14, 2024
JakobEliasWagner
force-pushed
the
join/feature-dataset
branch
from
February 14, 2024 14:21
42497cd
to
92d8a65
Compare
@samuelburbulla added your suggested changes to the PR. Need some clarification on whether you think it is okay to use xi in basics.ipynb. Furthermore, I do not have access to the flame dataset. |
samuelburbulla
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature/Cleanup: New Dataset Interface
Description
This pull request introduces an update to the datat-set handling mechanism.
It aims to leverage PyTorch's Dataset handling features to improve model's performance, scalability, ease of use, and maintainability.
Solves #31
Which issue does this PR tackle?
How does it solve the problem?
How are the changes tested?
Checklist for Contributors
feature/title-slug
convention.Bugfix: Title
convention.Checklist for Reviewers: