No more add browser bundles to git #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The main point of the browser bundle was not for testing actually (node support came a few years after). This library is available for browsers and I even make it available through CDNs, e.g.: https://cdnjs.cloudflare.com/ajax/libs/jschardet/1.4.1/jschardet.min.js |
|
Just noticed now the unpkg link. Can you shed some more light on it? Who’s maintaining this, is it realiable? |
|
@aadsm yes, it is reliable 👍 |
|
ping @jdesboeufs :) |
|
Yes? 😅 |
|
Oh! Sorry @jdesboeufs 🙏 I should ping @aadsm (repo owner :D) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #42
Since we don't need browser bundles for tests anymore, we should drop these bundles from git.
We could leverage on the
prepublishOnlytask to automate bundles build when publishing a new version.As
distare still packed, the will be available throughunpkg:https://unpkg.com/[email protected]/dist/jschardet.js