Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bLength, bDescriptorType and wTotalLength to descriptors #185

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

tuna-f1sh
Copy link
Contributor

Adds getters for bLength, bDescriptorType and wTotalLength to descriptors. Includes them in list devices lsusb verbose example to make it more feature complete.

Is there a reason these are not present and I'm missing it? Rather than ask in an issue I thought it's more productive to add them and ask here.

@tuna-f1sh
Copy link
Contributor Author

The macOS test fails on master so is unrelated. Seems to be something to do with libusb1-sys.

@a1ien
Copy link
Owner

a1ien commented Nov 13, 2023

The macOS is related to issues inside libusb itself. This bug will be fixed only in 1.0.27.
LGTM. I am also not remember why this fields is not exposed.

@a1ien a1ien merged commit c38563e into a1ien:master Nov 13, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants