Prepare 0.4.0 with attestation. #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update dependencies. Work towards a-scie#64.
jsirois
commented
Jul 3, 2024
| link_tables: "yes" | ||
| recurse_tables: "yes" | ||
| --- | ||
| :toctree_maxdepth: 2 |
There was a problem hiding this comment.
The Myst update warns about the deprecated directive option syntax and comment syntax (and our doc build treats warnings as errors); so this updates to the approved syntax for both options directives and comments.
jsirois
commented
Jul 3, 2024
| @@ -43,7 +43,7 @@ def run_pex(session: Session, script, *args, silent=False, **env) -> Any | None: | |||
| *args, | |||
| env={"PEX_SCRIPT": script, **env}, | |||
| silent=silent, | |||
| stderr=subprocess.DEVNULL if silent else None, | |||
| stderr=subprocess.DEVNULL if silent else subprocess.STDOUT, | |||
There was a problem hiding this comment.
Better type-checking flagged this.
jsirois
commented
Jul 3, 2024
| @@ -60,7 +61,7 @@ class DirectiveSpec: | |||
| name: str | |||
| args: tuple[str, ...] = () | |||
| options: Mapping[str, str] = FrozenDict() | |||
| content: str = "" | |||
| content: StringList = field(default_factory=StringList) | |||
There was a problem hiding this comment.
Updated docutils necessitated this change.
jsirois
commented
Jul 3, 2024
| @@ -133,7 +134,7 @@ def register( | |||
|
|
|||
| class Synthesized(Directive): | |||
| has_content = getattr(doc_gen_directive, "has_content", False) | |||
| option_spec: Mapping[str, Callable[[str], Any]] = { | |||
| option_spec = { | |||
There was a problem hiding this comment.
Better type-checking allowed this manual type ascription to be dropped.
benjyw
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update dependencies.
Work towards #64.