Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always use lit package and remove explicit lit-html #38

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

r3dDoX
Copy link
Member

@r3dDoX r3dDoX commented Jun 20, 2024

I think with older lit versions they recommended to have lit and lit-html as dependencies. That's why we still had them but they are not necessary anymore and we can just use lit

@r3dDoX r3dDoX force-pushed the feature/cleanup-dependencies branch from 6e6dea8 to 646e7df Compare June 22, 2024 13:43
@culas
Copy link
Member

culas commented Jun 30, 2024

In our project we removed the explicit lit-html dependency from the app, since it was already a transitive dependency coming from the web-components. But we still needed it, for example for custom table cell markup. That would still work after this change, also using lit itself from the app?

@r3dDoX
Copy link
Member Author

r3dDoX commented Jul 15, 2024

In our project we removed the explicit lit-html dependency from the app, since it was already a transitive dependency coming from the web-components. But we still needed it, for example for custom table cell markup. That would still work after this change, also using lit itself from the app?

Yes, that would still be working, since lit-html is a transitive dependency of lit

@r3dDoX r3dDoX merged commit 9780538 into main Jul 30, 2024
4 checks passed
@r3dDoX r3dDoX deleted the feature/cleanup-dependencies branch July 30, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants