Use generic app for bittensor

[camfairchild]

This changes the CLA to 0xf9 so Bittensor will be indicated as supporting the Generic Polkadot app.
We made the necessary runtime upgrade today.

🔗 zboto Link

[emmanuelm41]

Hey @camfairchild! Thanks for your contribution. I was reviewing it, and I think there is a misunderstanding. The generic app does not require any input like ss58 addr type or the slip0044. You can check the constructor here

ledger-substrate-js/src/generic_app.ts

Lines 57 to 65 in 5732e37

	constructor(transport: Transport, txMetadataChainId?: string, txMetadataSrvUrl?: string) {
	super(transport, PolkadotGenericApp._params)
	this.txMetadataSrvUrl = txMetadataSrvUrl
	this.txMetadataChainId = txMetadataChainId
	if (!this.transport) {
	throw new Error('Transport has not been defined')
	}
	}

The data you are updating is just for the legacy app, which you are actually abandoning, as you migrated to the generic app.

[camfairchild]

Hey @camfairchild! Thanks for your contribution. I was reviewing it, and I think there is a misunderstanding. The generic app does not require any input like ss58 addr type or the slip0044. You can check the constructor here

ledger-substrate-js/src/generic_app.ts

Lines 57 to 65 in 5732e37

	constructor(transport: Transport, txMetadataChainId?: string, txMetadataSrvUrl?: string) {
	super(transport, PolkadotGenericApp._params)
	this.txMetadataSrvUrl = txMetadataSrvUrl
	this.txMetadataChainId = txMetadataChainId
	if (!this.transport) {
	throw new Error('Transport has not been defined')
	}
	}

The data you are updating is just for the legacy app, which you are actually abandoning, as you migrated to the generic app.

Thanks for the response, I'm hoping to update what's required for the polkadotJS extension to list the network under Ledger apps that use the generic polkadot app.

If I'm not mistaken it uses this list.

[emmanuelm41]

@camfairchild we were not aware of the fact that polkadot js uses this list to add support to ledger device on the browser. Can you please point me to the place where that happens? It that is so, then this list is still relevant for them!

[camfairchild]

@camfairchild we were not aware of the fact that polkadot js uses this list to add support to ledger device on the browser. Can you please point me to the place where that happens? It that is so, then this list is still relevant for them!

Apologies, it appears they have stopped doing it that way, thanks for your help!¹

Closing in favour of: polkadot-js/common#1941

Footnotes

1. https://github.com/polkadot-js/common/blob/fbf3088d295db2f422f8357d42ab18e96c794102/packages/hw-ledger/src/defaults.ts#L4 ↩