Remove invalid data #75
Conversation
attempt to delete invalid data
attempt 2 to delete invalid data added some more data to clean more consistent Promise use
removed some unnecessary code
| @@ -7,16 +7,73 @@ $(function() { | |||
| airline = AES.getAirlineCode(); | |||
| server = AES.getServerName(); | |||
| chrome.storage.local.get(['settings'], function(result) { | |||
| settings = result.settings; | |||
| settings = result.settings; | |||
There was a problem hiding this comment.
Can I ask why you changed the indenting?
There was a problem hiding this comment.
that was not intentional
|
|
||
| displayDashboard(); | ||
| if ((settings['flightInformationsFixed'] === undefined) || (settings['flightInformationsFixed'] !== 1)) { |
There was a problem hiding this comment.
I thought it might be nice to base this on version number. Perhaps we could do if versionNumber < 0.6.9? What do you think?
There was a problem hiding this comment.
Of course you can do that, but i don't know when exactly the version number changes. So i used this simple "versioning" 1,2,3 in case further fixes are necessary and people already using this need to rerun this.
| }); | ||
| }); | ||
|
|
||
| function fixAndDeleteInvalidData() { |
There was a problem hiding this comment.
Can you please adjust the indent size to .editorconfig spec?
There was a problem hiding this comment.
Sure, had this set to two because the whole AES code was/is 2 spaces.
| chrome.storage.local.get(null, function (entries) { | ||
| const tasks = []; | ||
|
|
||
| function cleanAndSave(entry, key) { |
There was a problem hiding this comment.
Is there a reason this function is nested?
There was a problem hiding this comment.
It has access to entries then and functionallity belonged to fixAndDeleteInvalidData, nothing special.
Of course it can be written differently and also moved somewhere else if you want, in content_dashboard.js is already very large anyway.
But it's actually only there temporarily, isn't it?
There was a problem hiding this comment.
We should write code as if it were permanent.
Improving the code base is a long term project :)
There was a problem hiding this comment.
Well, i think this is a code style question. Just rewrite it according to your wishes. :)
| }); | ||
| }); | ||
|
|
||
| function fixAndDeleteInvalidData() { | ||
| chrome.storage.local.get(null, function (entries) { |
There was a problem hiding this comment.
It might be nice to get the data into a const with an await. Fewer nesting levels make the code easier to read.
There was a problem hiding this comment.
Yes maybe, it was just good good enough for temporary use. Do you want to change it?
There was a problem hiding this comment.
I would like you to change it, yes.
| Promise.all(tasks).then(() => { | ||
| chrome.storage.local.get('settings', function (result) { | ||
| const settings = result.settings || {}; | ||
| settings.flightInformationsFixed = 1; |
There was a problem hiding this comment.
perhaps instead of a 1 this could be true | false. Or better yet the current AES version number? That way we could verify / update the data in the future
There was a problem hiding this comment.
i added 1 one in case if it needs further fixing, see second answer above
fix: remove invalid data
fixes #20