Merge pull request #86 from ZettaScaleLabs/v36.1.1-rc5

Refine repr support
ZettaScaleLabs · Jul 6, 2024 · c71e794 · c71e794
2 parents caeccb0 + d99de71
commit c71e794
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 19 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+# 36.1.1-rc5 (api=2.0.0, abi=2.0.0)
+- Refine support for `#[repr(transparent)]` and `#[repr(align(n))]` in `#[stabby::stabby]` structs up to n=64kiB.
+
 # 36.1.1-rc4 (api=2.0.0, abi=2.0.0)
 - Add support for `#[repr(transparent)]` and `#[repr(align(n))]` in `#[stabby::stabby]` structs up to n=64kiB.
 

diff --git a/Cargo.toml b/Cargo.toml
@@ -33,12 +33,12 @@ license = " EPL-2.0 OR Apache-2.0"
 categories = ["development-tools::ffi", "no-std::no-alloc"]
 repository = "https://github.com/ZettaScaleLabs/stabby"
 readme = "stabby/README.md"
-version = "36.1.1-rc4"                                           # Track
+version = "36.1.1-rc5"                                           # Track
 
 [workspace.dependencies]
-stabby-macros = { path = "./stabby-macros/", version = "36.1.1-rc4", default-features = false } # Track
-stabby-abi = { path = "./stabby-abi/", version = "36.1.1-rc4", default-features = false }       # Track
-stabby = { path = "./stabby/", version = "36.1.1-rc4", default-features = false }               # Track
+stabby-macros = { path = "./stabby-macros/", version = "36.1.1-rc5", default-features = false } # Track
+stabby-abi = { path = "./stabby-abi/", version = "36.1.1-rc5", default-features = false }       # Track
+stabby = { path = "./stabby/", version = "36.1.1-rc5", default-features = false }               # Track
 
 abi_stable = "0.11.0"
 libc = "0.2"

diff --git a/stabby-macros/src/structs.rs b/stabby-macros/src/structs.rs
@@ -122,17 +122,15 @@ pub fn stabby(
     let clauses = where_clause.as_ref().map(|w| &w.predicates);
     let mut layout = None;
     let mut report = crate::Report::r#struct(ident.to_string(), version, module);
-    let repr = attrs
-        .iter()
-        .find_map(|attr| {
-            if attr.path.is_ident("repr") {
-                syn::parse2::<AllowedRepr>(attr.tokens.clone()).ok()
-            } else {
-                None
-            }
-        })
-        .unwrap_or(AllowedRepr::C);
-    optimize &= !matches!(repr, AllowedRepr::Align(_));
+    let repr = attrs.iter().find_map(|attr| {
+        if attr.path.is_ident("repr") {
+            syn::parse2::<AllowedRepr>(attr.tokens.clone()).ok()
+        } else {
+            None
+        }
+    });
+    let repr_attr = repr.is_none().then(|| quote! {#[repr(C)]});
+    optimize &= !matches!(repr, Some(AllowedRepr::Align(_)));
     let struct_code = match &fields {
         syn::Fields::Named(fields) => {
             let fields = &fields.named;
@@ -146,7 +144,7 @@ pub fn stabby(
             }
             quote! {
                 #(#attrs)*
-                #repr
+                #repr_attr
                 #vis struct #ident #generics #where_clause {
                     #fields
                 }
@@ -164,22 +162,22 @@ pub fn stabby(
             }
             quote! {
                 #(#attrs)*
-                #repr
+                #repr_attr
                 #vis struct #ident #generics #where_clause (#fields);
             }
         }
         syn::Fields::Unit => {
             quote! {
                 #(#attrs)*
-                #repr
+                #repr_attr
                 #vis struct #ident #generics #where_clause;
             }
         }
     };
     let layout = layout.map_or_else(
         || quote!(()),
         |layout| {
-            if let AllowedRepr::Align(mut n) = repr {
+            if let Some(AllowedRepr::Align(mut n)) = repr {
                 let mut align = quote!(#st::U1);
                 while n > 1 {
                     n /= 2;

diff --git a/stabby/src/tests/layouts.rs b/stabby/src/tests/layouts.rs
@@ -127,6 +127,12 @@ pub struct EndPadding {
     a: usize,
     b: u8,
 }
+#[allow(dead_code)]
+#[stabby::stabby]
+#[repr(transparent)]
+pub struct Transparent {
+    a: usize,
+}
 
 #[test]
 fn layouts() {
@@ -255,6 +261,8 @@ fn layouts() {
         3 * 16
     );
     let _ = Align1024::ID;
+    let _: U1024 = <Align1024 as IStable>::Align::default();
+    let _: U1024 = <Align1024 as IStable>::Size::default();
 }
 
 #[allow(dead_code)]