3

Yukang-Lian · Jul 12, 2023 · 700d364 · 700d364
1 parent e7ad4ce
commit 700d364
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 12 deletions.
diff --git a/be/src/olap/tablet.cpp b/be/src/olap/tablet.cpp
@@ -3286,7 +3286,7 @@ Status Tablet::full_compaction_update_delete_bitmap(const RowsetSharedPtr& rowse
     for (const auto& it : _rs_version_map) {
         const int64_t& cur_version = it.first.first;
         const RowsetSharedPtr& published_rowset = it.second;
-        if (it.first.first > max_version) {
+        if (cur_version > max_version) {
             RETURN_IF_ERROR(_full_compaction_calc_delete_bitmap(published_rowset, rowset,
                                                                 cur_version, rowset_writer));
         }

diff --git a/be/src/olap/tablet_meta.cpp b/be/src/olap/tablet_meta.cpp
@@ -26,7 +26,6 @@
 #include <json2pb/pb_to_json.h>
 #include <time.h>
 
-#include <mutex>
 #include <set>
 #include <utility>
 
@@ -932,11 +931,6 @@ void DeleteBitmap::remove(const BitmapKey& start, const BitmapKey& end) {
     }
 }
 
-void DeleteBitmap::clear() {
-    std::lock_guard l(lock);
-    delete_bitmap.clear();
-}
-
 bool DeleteBitmap::contains(const BitmapKey& bmk, uint32_t row_id) const {
     std::shared_lock l(lock);
     auto it = delete_bitmap.find(bmk);

diff --git a/be/src/olap/tablet_meta.h b/be/src/olap/tablet_meta.h
@@ -349,11 +349,6 @@ class DeleteBitmap {
      */
     void remove(const BitmapKey& lower_key, const BitmapKey& upper_key);
 
-    /**
-     * Clears all bitmaps
-     */
-    void clear();
-
     /**
      * Checks if the given row is marked deleted
      *