Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

U2F key_lookup: do not fail upon SW_WRONG_LENGTH (0x6700) #819

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

James-ZHANG
Copy link
Contributor

@James-ZHANG James-ZHANG commented Sep 13, 2024

According to u2f spec: https://fidoalliance.org/specs/fido-u2f-v1.2-ps-20170411/fido-u2f-raw-message-formats-v1.2-ps-20170411.html#status-codes, U2F security keys can return 0x6700 in addition to 0x6A80 when given invalid key handles.

This occurs to our internally developed security keys when the key handle is too long.

@martelletto
Copy link
Contributor

LGTM

Copy link
Contributor

@LDVG LDVG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LDVG LDVG merged commit 98aa428 into Yubico:main Sep 16, 2024
37 checks passed
@James-ZHANG James-ZHANG deleted the fix-u2f-lookup branch October 11, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants