Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PC/SC support on Linux #716

Closed
wants to merge 2 commits into from
Closed

Add PC/SC support on Linux #716

wants to merge 2 commits into from

Conversation

mlpformat
Copy link

This may allow additional NFC hardware to be used on Linux and others. I'm unable to test with NFC, but it works with a Cryptnox FIDO Card in a contact reader.

This should allow more NFC hardware to be used on Linux and other Unix-likes. I don't have supported NFC hardware to test, but it works with a Cryptnox FIDO Card in a contact reader.
@LDVG
Copy link
Contributor

LDVG commented Aug 17, 2023

Hi,

We rely on pkg-config to set the appropriate -I flag. See e.g. our cmake output

...
-- PCSC_INCLUDE_DIRS: /usr/include/PCSC
-- PCSC_LIBRARIES: pcsclite
-- PCSC_LIBRARY_DIRS: /usr/lib
-- PCSC_VERSION: 1.9.9
...

and the output of a call to make

...
[ 15%] Building C object src/CMakeFiles/fido2_shared.dir/pcsc.c.o
cd /__w/libfido2/libfido2/build-Debug/src && /usr/bin/gcc <snip> -I/usr/include/PCSC <snip> 
...

(additional compiler flags omitted for brevity)

The current choice of using the #else branch for Linux should therefore be correct and I'll be closing this with no action. Let us know if there's something we're missing.

Thanks!

@LDVG LDVG closed this Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants