Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runSCENIC function to sclet #6

Open
wants to merge 7 commits into
base: devel
Choose a base branch
from

Conversation

ruiwang0236
Copy link

No description provided.

@GuangchuangYu
Copy link
Member

不能只有代码,给一个可以写到文档里的,可以运行重复出来的例子。

R/runSCENIC.R Outdated
minCountsPerGene = 3,
minSamples = 0.01){
dir.create("int")
# 设置物种和TF数据库路径
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不要在代码里使用中文。

SCENIC.Rmd Outdated
library(sclet)

# use demo data from SCENIC, mousebrain_sce
sce <- readRDS("data/mousebrain_SCENIC_sce.Rds")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我说要一个可以重复的例子,你觉得这个可以重复?数据只在你的电脑里。

SCENIC.Rmd Outdated
# use demo data from SCENIC, mousebrain_sce
sce <- readRDS("data/mousebrain_SCENIC_sce.Rds")
scenicOptions <- runSCENIC(sce, mouse, 10,
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这一句都没写完,自己都没试过能不能跑通。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

示例和代码是分开的,示例放的是这个分支,https://github.com/YuLab-SMU/sclet/tree/gh-pages.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

写示例,不是写一个简单的代码,你看,能跑通。例子需要解说。对于输入、输出、结果解说,尽可能详细地把事情说清楚。

## code to prepare `DATASET` dataset goes here

load("./inst/ext/defaultDbNames.RData")
usethis::use_data(defaultDbNames, overwrite = TRUE)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个数据集并不需要。你的代码里并没有访问到这个数据,而是使用SCENIC::defaultDbNames访问的。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants