273 add bottom upsell and upsell sidebar

[thijsoo]

Context

• We want to show our adds in the alert centre part of the general page.

Summary

This PR can be summarized in the following changelog entry:

• Adds upsells to the redesign of the general page.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

• Add define( 'YOAST_SEO_NEW_DASHBOARD_UI', true ); to your project.
• Make sure the ads only show up on the alert centre part of the page and not in the FTC.
• Make sure the ads go away when premium is enabled.

Relevant test scenarios

• Changes should be tested with the browser console open
• Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
• Changes should be tested on different browsers
• Changes should be tested on multisite

Test instructions for QA when the code is in the RC

• QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

• This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

• This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

• I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

• I have tested this code to the best of my abilities.
• During testing, I had activated all plugins that Yoast SEO provides integrations for.
• I have added unit tests to verify the code works as intended.
• If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
• I have written this PR in accordance with my team's definition of done.
• I have checked that the base branch is correctly set.

Innovation

• No innovation project is applicable for this PR.
• This PR falls under an innovation project. I have attached the innovation label.
• I have added my hours to the WBSO document.

Fixes #

[coveralls]

Pull Request Test Coverage Report for Build 63348ae6f3d3c8977f22df79a2db5933af808dbc

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 25 (0.0%) changed or added relevant lines in 5 files are covered.
• 24 unchanged lines in 3 files lost coverage.
• Overall coverage increased (+5.2%) to 54.546%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
admin/class-config.php	0	3	0.0%
packages/js/src/settings/app.js	0	3	0.0%
packages/js/src/dashboard/routes/alert-center.js	0	4	0.0%
packages/js/src/shared-admin/components/premium-upsell-list.js	0	6	0.0%
packages/js/src/dashboard/components/sidebar-recommendations.js	0	9	0.0%

Files with Coverage Reduction	New Missed Lines	%
packages/js/src/dashboard/routes/alert-center.js	1	0.0%
packages/js/src/settings/app.js	1	0.0%
admin/menu/class-admin-menu.php	22	0.0%

Totals
Change from base Build 1302935e7835f8706e125480188684ab2d6af52c:	5.2%
Covered Lines:	29531
Relevant Lines:	54418

---

💛 - Coveralls