adjust removemeshuser to allow for shorter user ids #6520
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stumbled across this issue when trying to remove a user from a mesh using meshctrl
removeuserfromdevicegroup
. I was attempting to removeuser1
from a mesh and receivedInvalid userid
. After adjusting the Id touser//user1
, the command would proceed without issue. At first I just figured the function required the full Id with the prefix, but thought that odd asaddusertodevicegroup
distinctly does NOT accept the prefix.After looking at the code, the function requires a minimum of 8 characters for the user Id. This causes issues when using meshctrl with Ids under 8 characters. This will also cause an issue in the web UI for Ids of only 1 character. User
user//a
does not satisfy the length requirement and cannot be removed from a mesh in the web UI.