Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gold & Collectible Spawning #84

Merged
merged 5 commits into from
Mar 23, 2024
Merged

Gold & Collectible Spawning #84

merged 5 commits into from
Mar 23, 2024

Conversation

Rxann
Copy link
Contributor

@Rxann Rxann commented Mar 18, 2024

Allows rewards and collectibles to be spawned in game.

Thanks @tyackman and @Deadlineem for the help

closes #80

Copy link
Member

@Yimura Yimura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This goes against the principles of integrating recovery features into a menu (specifically how YimMenu does it).

Though I really don't have any strong feelings for HorseMenu as I'm not really the person supposed to manage this.

@Rxann
Copy link
Contributor Author

Rxann commented Mar 19, 2024

This goes against the principles of integrating recovery features into a menu (specifically how YimMenu does it).

Though I really don't have any strong feelings for HorseMenu as I'm not really the person supposed to manage this.

oh yeah i should have expected this. who manages it? would it still be possible to merge even though it sort of goes against the principles?

@Deadlineem
Copy link
Contributor

This goes against the principles of integrating recovery features into a menu (specifically how YimMenu does it).

Though I really don't have any strong feelings for HorseMenu as I'm not really the person supposed to manage this.

Who is supposed to manage this? This project is similar to YimMenu and has alot of potential however ik rdr2 is a bit dead.

Id love to see at least a lua scripts addition to this menu like Yim has in it, that would open a ton of possibilities for myself and others tbh.

@Rxann
Copy link
Contributor Author

Rxann commented Mar 20, 2024

This goes against the principles of integrating recovery features into a menu (specifically how YimMenu does it).

Though I really don't have any strong feelings for HorseMenu as I'm not really the person supposed to manage this.

Who is supposed to manage this? This project is similar to YimMenu and has alot of potential however ik rdr2 is a bit dead.

Id love to see at least a lua scripts addition to this menu like Yim has in it, that would open a ton of possibilities for myself and others tbh.

Lua scripts is a big project 🤣

@Yimura I did however remember that red dead online is not actively developed so we would not need to worry about being targeted like YimMenu with recovery features.

Copy link

github-actions bot commented Mar 21, 2024

Download the artifacts for this pull request:

@Rxann
Copy link
Contributor Author

Rxann commented Mar 21, 2024

there are merge conflicts for this? I am not at home so I can't see what they are

@Rxann
Copy link
Contributor Author

Rxann commented Mar 21, 2024

alright conflicts have been resolved

@DayibBaba
Copy link
Contributor

I am supposed to manage this :|. I have not decided on the recovery, depends on whether refraining from it on YimMenu has kept R* of our backs or not. Keep this open, ill discuss it with the yim team if they are interested to sound their opinions.

@Rxann
Copy link
Contributor Author

Rxann commented Mar 22, 2024

I am supposed to manage this :|. I have not decided on the recovery, depends on whether refraining from it on YimMenu has kept R* of our backs or not. Keep this open, ill discuss it with the yim team if they are interested to sound their opinions.

Okay, I will keep this open. Idk if it helps but Red Dead Online isn't under active development anymore they only patch bugs so it would be improbable that they target us.

@Deadlineem
Copy link
Contributor

Deadlineem commented Mar 22, 2024

I am supposed to manage this :|. I have not decided on the recovery, depends on whether refraining from it on YimMenu has kept R* of our backs or not. Keep this open, ill discuss it with the yim team if they are interested to sound their opinions.

If it helps, this drops sets of collectibles but you still have to pick them up 1 by 1 so it takes a bit, i tested it and compared to seeing another modder spawning treasure chests in the streets, this is a super light recovery method.

Im down to make this like yim for gta, not in terms of styling, but functionality. Its actually helping me learn C++ as well and since it has only a handful of features, makes it easy to find/navigate where i need to be to add/change things

@DayibBaba
Copy link
Contributor

I am supposed to manage this :|. I have not decided on the recovery, depends on whether refraining from it on YimMenu has kept R* of our backs or not. Keep this open, ill discuss it with the yim team if they are interested to sound their opinions.

If it helps, this drops sets of collectibles but you still have to pick them up 1 by 1 so it takes a bit, i tested it and compared to seeing another modder spawning treasure chests in the streets, this is a super light recovery method.

Im down to make this like yim for gta, not in terms of styling, but functionality. Its actually helping me learn C++ as well and since it has only a handful of features, makes it easy to find/navigate where i need to be to add/change things

I have decided not to enforce anti-recovery policy for this project. However, I will require all recovery options to employ a disclaimer.

@Rxann
Copy link
Contributor Author

Rxann commented Mar 22, 2024

I am supposed to manage this :|. I have not decided on the recovery, depends on whether refraining from it on YimMenu has kept R* of our backs or not. Keep this open, ill discuss it with the yim team if they are interested to sound their opinions.

If it helps, this drops sets of collectibles but you still have to pick them up 1 by 1 so it takes a bit, i tested it and compared to seeing another modder spawning treasure chests in the streets, this is a super light recovery method.

Im down to make this like yim for gta, not in terms of styling, but functionality. Its actually helping me learn C++ as well and since it has only a handful of features, makes it easy to find/navigate where i need to be to add/change things

I have decided not to enforce anti-recovery policy for this project. However, I will require all recovery options to employ a disclaimer.

I will make this asap.

@Rxann
Copy link
Contributor Author

Rxann commented Mar 23, 2024

@DayibBaba alright it has been updated, ready for merge?

@DayibBaba
Copy link
Contributor

DayibBaba commented Mar 23, 2024

@DayibBaba alright it has been updated, ready for merge?

I appreciate how active you are and the contributions you are providing. But, to not risk overlooking small errors and bury them deep, I will from now on test PR's before merging. Currently installing Rdr2 to my device.

EDIT:
Just checked your changes in game. Functionality wise it seems proper, but the disclaimer is out of bounds for the UI.

src/game/frontend/submenus/Self.cpp Outdated Show resolved Hide resolved
src/game/frontend/submenus/Self.cpp Outdated Show resolved Hide resolved
@Rxann
Copy link
Contributor Author

Rxann commented Mar 23, 2024

Is this a good new solution?

@Rxann Rxann requested a review from DayibBaba March 23, 2024 13:13
@DayibBaba
Copy link
Contributor

Is this a good new solution?

Yes, however, I still want it in a group and maybe make the selectables activate on double click. Call the group Spawn Collectibles and remove all "Spawn all" prefixes.

@Rxann
Copy link
Contributor Author

Rxann commented Mar 23, 2024

Is this a good new solution?

Yes, however, I still want it in a group and maybe make the selectables activate on double click. Call the group Spawn Collectibles and remove all "Spawn all" prefixes.

Okay, I will put it into a group called Spawn Colectibles. What dimensions do you think would be good for the group? Earlier, you discovered that the GetListBoxDimensions was not enough because of the large text. Do you think 1 or 2 columns should be created in the new "page" for recovery?

@DayibBaba
Copy link
Contributor

Is this a good new solution?

Yes, however, I still want it in a group and maybe make the selectables activate on double click. Call the group Spawn Collectibles and remove all "Spawn all" prefixes.

Okay, I will put it into a group called Spawn Colectibles. What dimensions do you think would be good for the group? Earlier, you discovered that the GetListBoxDimensions was not enough because of the large text. Do you think 1 or 2 columns should be created in the new "page" for recovery?

Currently our Interface facilities are lack-luster. Use GetListBoxDimensions to have the sizes modular and fixable for the future.

@Rxann
Copy link
Contributor Author

Rxann commented Mar 23, 2024

Is this a good new solution?

Yes, however, I still want it in a group and maybe make the selectables activate on double click. Call the group Spawn Collectibles and remove all "Spawn all" prefixes.

Okay, I will put it into a group called Spawn Colectibles. What dimensions do you think would be good for the group? Earlier, you discovered that the GetListBoxDimensions was not enough because of the large text. Do you think 1 or 2 columns should be created in the new "page" for recovery?

Currently our Interface facilities are lack-luster. Use GetListBoxDimensions to have the sizes modular and fixable for the future.

Alright. Do you think 2 columns should be good for now?

@DayibBaba
Copy link
Contributor

Is this a good new solution?

Yes, however, I still want it in a group and maybe make the selectables activate on double click. Call the group Spawn Collectibles and remove all "Spawn all" prefixes.

Okay, I will put it into a group called Spawn Colectibles. What dimensions do you think would be good for the group? Earlier, you discovered that the GetListBoxDimensions was not enough because of the large text. Do you think 1 or 2 columns should be created in the new "page" for recovery?

Currently our Interface facilities are lack-luster. Use GetListBoxDimensions to have the sizes modular and fixable for the future.

Alright. Do you think 2 columns should be good for now?

Yes, those can be adjusted as needed.

@Rxann
Copy link
Contributor Author

Rxann commented Mar 23, 2024

@DayibBaba alright this should be good.

@DayibBaba DayibBaba merged commit 2a1d611 into YimMenu:master Mar 23, 2024
1 check passed
@Rxann Rxann deleted the gold branch July 21, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Gold/Income & LUA scripts
4 participants