Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ped Spawner, Drunkness, NPC Ignore, Ragdoll, and Fix Metric Blocking #81

Merged
merged 4 commits into from
Mar 24, 2024

Conversation

Rxann
Copy link
Contributor

@Rxann Rxann commented Mar 16, 2024

Things I added:
Ped Spawner - spawn all of the peds in the game that I could find.
Drunkness - Applies drunken effect
NPC Ignore - Use natives to have npcs completely ignore you.
Ragdoll - Ragdoll anyone in the lobby.
Fix Metric Blocking - return original function instead of true because returning true was not actually sending the metrics(to my knowledge)

Copy link

github-actions bot commented Mar 19, 2024

Download the artifacts for this pull request:

@Rxann
Copy link
Contributor Author

Rxann commented Mar 21, 2024

conflicts have been resolved

Copy link
Contributor

@DayibBaba DayibBaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the SendMetric change, need @maybegreat48 to check that one.

src/game/features/players/toxic/Ragdoll.cpp Outdated Show resolved Hide resolved
src/game/features/self/Drunk.cpp Outdated Show resolved Hide resolved
src/util/PedModels.hpp Show resolved Hide resolved
src/util/SpawnPed.cpp Show resolved Hide resolved
src/util/SpawnPed.cpp Show resolved Hide resolved
src/util/SpawnPed.cpp Outdated Show resolved Hide resolved
src/util/SpawnPed.cpp Show resolved Hide resolved
src/util/SpawnPed.cpp Outdated Show resolved Hide resolved
@Rxann
Copy link
Contributor Author

Rxann commented Mar 23, 2024

Changes have been implemented. I said this on the review comment, but an if statement works better when requesting the model compared to a for or while loop. I have tested it. A block all telemetry option has also been implemented.

Copy link
Contributor

@DayibBaba DayibBaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge once @maybegreat48 approves.

Copy link
Contributor

@maybegreat48 maybegreat48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DayibBaba DayibBaba merged commit 97bc903 into YimMenu:master Mar 24, 2024
1 check passed
@Rxann Rxann deleted the toxic branch March 24, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants