updated add weather changer and time changer and force lighting flash #79

theofficialhackclean · 2024-03-15T20:42:27Z

No description provided.

Rxann · 2024-03-15T23:06:48Z

src/game/frontend/submenus/World/weather.hpp

+    "WHITEOUT",
+};
+
+void RDR2_ChangeWeather(const char* weather)


I would remove the rdr2 at the beginning of the function name

Rxann · 2024-03-15T23:06:59Z

src/game/frontend/submenus/World/weather.hpp

+{
+	MISC::_SET_OVERRIDE_WEATHER(MISC::GET_HASH_KEY(weather));
+}
+void RDR2_ChangeTime(int H = 12, int M = 0, int S = 0, int transition = 0, bool freeze = false)


Rxann · 2024-03-15T23:08:31Z

src/game/frontend/submenus/World/weather.hpp

@@ -0,0 +1,34 @@
+#include <game/rdr/Natives.hpp>
+inline const char* WeatherTypes[]{


maybe turn this into an unordered_map and i don't believe the inlining is required I could be wrong though

Keep the array

Inline is required (not here in this specific case but it's a good thing to remember due to how header files work)

Okay, I will remeber the inlining. I am curious, why would an array be better here? I guess an array and unordered_map are pretty close to the same thing.

Rxann · 2024-03-15T23:10:03Z

other than that the code looks good to me

maybegreat48 · 2024-03-15T23:42:52Z

src/game/frontend/submenus/World/weather.hpp

@@ -0,0 +1,34 @@
+#include <game/rdr/Natives.hpp>


These need to be converted to commands. You can inline them in world.cpp if you don't know how for now

src/game/frontend/submenus/world.cpp

added the force light that i thought i added

Rxann

these are my observations

Rxann · 2024-03-18T02:04:57Z

src/game/frontend/submenus/World/weather.hpp

+{
+	MISC::_SET_OVERRIDE_WEATHER(MISC::GET_HASH_KEY(weather));
+}
+void ChangeTime(int H = 12, int M = 0, int S = 0, int transition = 0, bool freeze = false)


turn into a command

well not everything needs to be a command for example where you play the animations you could say to make the a command so yeah i think that is fine i put every thing else as a command because i thought it was right but i don't think that the time changer has to be a command or change weather has to it can be one but at the end it doesn't have too

I do agree here, because there are not methods to pass arguments to commands(minutes, hours, etc) so that makes sense.

Rxann · 2024-03-18T02:05:31Z

src/game/frontend/submenus/World/weather.hpp

+	NETWORK::_NETWORK_CLOCK_TIME_OVERRIDE(H, M, S, transition, freeze);
+}
+
+namespace yimmenu


Rxann · 2024-03-18T02:05:47Z

src/game/frontend/submenus/World/weather.hpp

+{
+	namespace Features
+	{
+		class forcelighting: public Command


ForceLightning <- correct case and correct spelling

Rxann · 2024-03-18T02:06:06Z

src/game/frontend/submenus/World/weather.hpp

+		};
+
+
+		static forcelighting _forcelighting{"forcelighting", "force lighting", "spawn lighting "};


ForceLightning

Rxann · 2024-03-18T02:09:35Z

src/game/frontend/submenus/World/weather.hpp

+		public:
+			using Command::Command;
+
+			virtual void OnCall() override


i dont known how this native works, but if it only works once, you could turn this into a looped command to make it happen more than just once per button press. just an idea tho

theofficialhackclean · 2024-03-20T15:08:53Z

everything should be fixed

dwsiddall · 2024-03-21T16:06:20Z

Sorry to be a big dummy, but how do I integrate this change into the menu? Or is it that once it's approved it will be integrated into an updated DLL?

I would really like to be able to control the time and weather.

Rxann · 2024-03-21T17:28:23Z

Sorry to be a big dummy, but how do I integrate this change into the menu? Or is it that once it's approved it will be integrated into an updated DLL?

I would really like to be able to control the time and weather.

Once the change is approved, known more commonly as mergered, an automatic process will run everyday that checks to see if a new DLL needs to be built and then your change will be built into that. This pr currently adds this so once this is approved, it will be in the menu.

GrymRpr · 2024-03-21T19:38:54Z

Sorry to be a big dummy, but how do I integrate this change into the menu? Or is it that once it's approved it will be integrated into an updated DLL?
I would really like to be able to control the time and weather.

Once the change is approved, known more commonly as mergered, an automatic process will run everyday that checks to see if a new DLL needs to be built and then your change will be built into that. This pr currently adds this so once this is approved, it will be in the menu.

Thanks.

theofficialhackclean · 2024-03-22T20:14:54Z

fixed 👍 I'm a dummy lol

maybegreat48 · 2024-03-30T16:43:53Z

src/game/frontend/submenus/world.cpp

+
+
+
+		weather->AddItem(std::make_shared<ImGuiItem>([] {


Might be a good idea to mention that this is purely local

maybegreat48 · 2024-03-30T17:15:33Z

src/game/frontend/submenus/World/weather.hpp

@@ -0,0 +1,60 @@
+


Add a #pragma once here

theofficialhackclean added 8 commits March 15, 2024 16:32

Update Menu.cpp

4b5c9a2

Add files via upload

2246b3c

Update world.cpp

6409ba3

Create weather.hpp

b45dc7f

Update weather.hpp

84c3f23

Update world.cpp

72fb7a7

Update world.hpp

cacc63e

Update world.cpp

dfb03a9

Rxann reviewed Mar 15, 2024

View reviewed changes

maybegreat48 reviewed Mar 15, 2024

View reviewed changes

src/game/frontend/submenus/world.cpp Outdated Show resolved Hide resolved

theofficialhackclean added 3 commits March 15, 2024 20:29

Update world.cpp

eca9f61

Update weather.hpp

3b441eb

Update world.cpp

b93af8f

theofficialhackclean requested a review from maybegreat48 March 16, 2024 12:56

theofficialhackclean added 3 commits March 16, 2024 09:49

Update weather.hpp

caa3cc9

added the force light that i thought i added

Update world.cpp

1a36a76

Update weather.hpp

785d1f4

theofficialhackclean requested a review from Rxann March 16, 2024 22:19

Rxann reviewed Mar 18, 2024

View reviewed changes

theofficialhackclean requested a review from Rxann March 18, 2024 15:22

theofficialhackclean added 3 commits March 18, 2024 11:38

Update weather.hpp

dbaa767

Update weather.hpp

ff64158

Update weather.hpp

9de57be

theofficialhackclean added 2 commits March 22, 2024 16:13

Update world.cpp

006e926

Update world.hpp

fe706ba

Deadlineem mentioned this pull request Mar 29, 2024

REQ: Weather and Time #123

Closed

maybegreat48 reviewed Mar 30, 2024

View reviewed changes

src/game/frontend/submenus/World/weather.hpp

@@ -0,0 +1,60 @@

Copy link

Contributor

maybegreat48 Mar 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a #pragma once here

MarkEcza approved these changes May 28, 2024

View reviewed changes

MarkEcza merged commit f0c61ae into YimMenu:master May 28, 2024

Rxann mentioned this pull request May 31, 2024

Fix Failing Nightly CI #142

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

updated add weather changer and time changer and force lighting flash #79

updated add weather changer and time changer and force lighting flash #79

theofficialhackclean commented Mar 15, 2024

Rxann Mar 15, 2024

theofficialhackclean Mar 16, 2024

Rxann Mar 15, 2024

theofficialhackclean Mar 16, 2024

Rxann Mar 15, 2024

xiaoxiao921 Mar 15, 2024

Rxann Mar 16, 2024

Rxann commented Mar 15, 2024

maybegreat48 Mar 15, 2024

Rxann left a comment

Rxann Mar 18, 2024

theofficialhackclean Mar 18, 2024 •

edited

Loading

Rxann Mar 18, 2024

Rxann Mar 18, 2024

Rxann Mar 18, 2024

Rxann Mar 18, 2024

Rxann Mar 18, 2024

theofficialhackclean commented Mar 20, 2024

dwsiddall commented Mar 21, 2024 •

edited

Loading

Rxann commented Mar 21, 2024

GrymRpr commented Mar 21, 2024

theofficialhackclean commented Mar 22, 2024 •

edited

Loading

maybegreat48 Mar 30, 2024

maybegreat48 Mar 30, 2024

		@@ -0,0 +1,34 @@
		#include <game/rdr/Natives.hpp>
		inline const char* WeatherTypes[]{

		};


		static forcelighting _forcelighting{"forcelighting", "force lighting", "spawn lighting "};

updated add weather changer and time changer and force lighting flash #79

updated add weather changer and time changer and force lighting flash #79

Conversation

theofficialhackclean commented Mar 15, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Rxann commented Mar 15, 2024

Choose a reason for hiding this comment

Rxann left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

theofficialhackclean Mar 18, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

theofficialhackclean commented Mar 20, 2024

dwsiddall commented Mar 21, 2024 • edited Loading

Rxann commented Mar 21, 2024

GrymRpr commented Mar 21, 2024

theofficialhackclean commented Mar 22, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

theofficialhackclean Mar 18, 2024 •

edited

Loading

dwsiddall commented Mar 21, 2024 •

edited

Loading

theofficialhackclean commented Mar 22, 2024 •

edited

Loading