Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vehicle Spawner + Fix 3 Bugs that Caused the Menu to be Unusable #78

Merged
merged 10 commits into from
Mar 21, 2024

Conversation

Rxann
Copy link
Contributor

@Rxann Rxann commented Mar 2, 2024

Things I changed:
Fixed the crash that was caused by the folder for settings being in Documents, so it is now in appdata.
Added a mutex to notifications to fix a crash that was caused.
Fixed/removed debug menu, so there is no longer a crash when clicking into the debug menu
Added a vehicle spawner function, and then added the interface for spawning a bounty wagon for you or another user.

Let me know if there are any code issues, but functionally it works well.

Fixes #76
Possible fix for #48 but we will see

Fixes menu crashing on start and now the menu will actually save logs + settings
Fixes crash on display of notifications
New function to get the full filepath of the settings file
Commented out the debug submenu because when you click it, a crash occours
New easy way to check if player is host
Rxann added a commit to Rxann/HorseMenu that referenced this pull request Mar 2, 2024
@DayibBaba
Copy link
Contributor

Why did you feel like appdata would be better suited to host the files?

@Rxann
Copy link
Contributor Author

Rxann commented Mar 2, 2024

Why did you feel like appdata would be better suited to host the files?

When using documents, the menu would crash on load and not save the files, etc.

I don't know if this was just a me issue, I wouldn't be surprised if it was but YimMenu also uses appdata and I think its a generally good place.

@Hyman-R
Copy link

Hyman-R commented Mar 9, 2024

Please update the binary release so that we can share the fixed version, thanks.

Copy link

github-actions bot commented Mar 12, 2024

Download the artifacts for this pull request:

src/util/VehicleSpawner.hpp Outdated Show resolved Hide resolved
src/util/VehicleSpawner.cpp Outdated Show resolved Hide resolved
@MarkEcza MarkEcza mentioned this pull request Mar 12, 2024
@Rxann
Copy link
Contributor Author

Rxann commented Mar 12, 2024

@MarkEcza thanks for the review, i will have these things fixed in like 7 hours 🤣

@Rxann Rxann requested a review from MarkEcza March 12, 2024 20:28
src/main.cpp Outdated Show resolved Hide resolved
@Rxann
Copy link
Contributor Author

Rxann commented Mar 20, 2024

@Yimura do you want me to change it back to the documents / "HorseMenu" in the Filemgr call?

@Yimura
Copy link
Member

Yimura commented Mar 20, 2024

@Yimura do you want me to change it back to the documents / "HorseMenu" in the Filemgr call?

I don't really care about the save location really, I do care about the /= weirdness. I'd just use / instead.

@Rxann
Copy link
Contributor Author

Rxann commented Mar 20, 2024

@Yimura do you want me to change it back to the documents / "HorseMenu" in the Filemgr call?

I don't really care about the save location really, I do care about the /= weirdness. I'd just use / instead.

alright it has been fixed 👍

@Rxann Rxann requested a review from Yimura March 20, 2024 20:08
@Yimura Yimura merged commit 41b81ed into YimMenu:master Mar 21, 2024
1 check passed
@Rxann Rxann deleted the veh-spawner branch July 21, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on load
5 participants