-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vehicle Spawner + Fix 3 Bugs that Caused the Menu to be Unusable #78
Conversation
Fixes menu crashing on start and now the menu will actually save logs + settings
Fixes crash on display of notifications
New function to get the full filepath of the settings file
Commented out the debug submenu because when you click it, a crash occours
New easy way to check if player is host
Why did you feel like appdata would be better suited to host the files? |
When using documents, the menu would crash on load and not save the files, etc. I don't know if this was just a me issue, I wouldn't be surprised if it was but YimMenu also uses appdata and I think its a generally good place. |
Please update the binary release so that we can share the fixed version, thanks. |
Download the artifacts for this pull request: |
@MarkEcza thanks for the review, i will have these things fixed in like 7 hours 🤣 |
@Yimura do you want me to change it back to the |
I don't really care about the save location really, I do care about the |
alright it has been fixed 👍 |
Things I changed:
Fixed the crash that was caused by the folder for settings being in Documents, so it is now in appdata.
Added a mutex to notifications to fix a crash that was caused.
Fixed/removed debug menu, so there is no longer a crash when clicking into the debug menu
Added a vehicle spawner function, and then added the interface for spawning a bounty wagon for you or another user.
Let me know if there are any code issues, but functionally it works well.
Fixes #76
Possible fix for #48 but we will see