fix(dropdown) : 드롭다운 외부클릭 시 닫기 기능을 추가합니다. #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-image 24-02-18 21:15 WEB 1.1 BUG FIX
caseBread
requested review from
anveloper,
da-in,
headring,
hey210056 and
wogha95
as code owners
da-in
approved these changes
Mar 2, 2024
da-in
approved these changes
Mar 2, 2024
| onClose: () => void; | ||
| }; | ||
|
|
||
| const Popover: React.FC<TProps> = ({ className, children, onClose }) => { |
There was a problem hiding this comment.
컴포넌트 props 타이핑이 컴포넌트마다 조금씩 상이해서, 컨벤션을 정해도 좋겠네요🤔
There was a problem hiding this comment.
아니 체다 저 멘션도 안걸었는데 작업한지 어케 아신건지 ㅋㅋㅋㅋ 칼리뷰 정말 감사합니다 🥹🙇♂️
props 타이핑이 React.FC<TProps> 요부분이죠?
저거 회사컨벤션이라 무의식중에 사용된것 같아요😅
심플썸네일에서 컨벤션이 따로 없지만, 심플썸네일에서 자주쓰는 방식으로 변경해두겠슴다!
추후 컨벤션을 정해봐도 좋을것같아요
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ PR 타입
📝 개요
💽 작업 사항