refactor!: remove SignableRequest #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaneur2020
changed the title
flaneur2020
changed the title
Xuanwo
approved these changes
Aug 8, 2024
Xuanwo
changed the title
|
@Xuanwo can you help release a version of reqsign? i'll raise a pr in opendal with the related api changes |
Hi, thank you very much for your effort. I plan to review the entire codebase to evaluate the overall design before making a release. This will happen today. |
Xuanwo
pushed a commit
that referenced
this pull request
Aug 9, 2024
sorry i did not recognize that the readme is also needed to be modified in #463 if there're other docs need to be modified together, please let me know
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR removes SignableRequest trait and moved the convert logic into SigningContext directly.
now instead of signing an
Requestobject, we choose to sign thehttp::request::Parts.with this refactor, we can shrink the compiled binary without the duplication introduced from different generic parameters.
this is considered as a BREAKING CHANGE of the api.
fixes #460