Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove SignableRequest #460

Closed
flaneur2020 opened this issue Aug 6, 2024 · 2 comments · Fixed by #463
Closed

refactor: remove SignableRequest #460

flaneur2020 opened this issue Aug 6, 2024 · 2 comments · Fixed by #463
Assignees
@flaneur2020

Comments

@flaneur2020
Copy link
Contributor 

          Thanks a lot for your PR! However I'm thinking of a big refactor that build a `Sign` for entire reqsign. And we can remove the `SignableRequest` concept entirely by just support `http`. Do you have interest in this?

Originally posted by @Xuanwo in #459 (comment)
@flaneur2020
Copy link
Contributor Author

@Xuanwo can you help assign this issue to me?

@flaneur2020 flaneur2020 changed the title refactor: removes SignableRequest refactor: remove SignableRequest Aug 6, 2024
@Xuanwo
Copy link
Owner

Xuanwo commented Aug 6, 2024

Great, have fun!

@flaneur2020 flaneur2020 mentioned this issue Aug 8, 2024
Merged
Xuanwo pushed a commit that referenced this issue Aug 8, 2024
@flaneur2020
refactor: remove SignableRequest (#463)
b2df429 
this PR removes SignableRequest trait and moved the convert logic into
SigningContext directly.

now instead of signing an `Request` object, we choose to sign the
`http::request::Parts`.

with this refactor, we can shrink the compiled binary without the
duplication introduced from different generic parameters.

this is considered as a BREAKING CHANGE of the api.

fixes #460
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flaneur2020 flaneur2020

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor!: remove SignableRequest flaneur2020/reqsign
2 participants
@flaneur2020 @Xuanwo