Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: legalization from xten_nn.reduce_mean to aten.mean.dim #89

Merged
merged 4 commits into from
Sep 20, 2024
Merged

feat: legalization from xten_nn.reduce_mean to aten.mean.dim #89

merged 4 commits into from
Sep 20, 2024

Conversation

ehsan-toosi
Copy link
Contributor

No description provided.

p-lanza
p-lanza reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@p-lanza p-lanza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though admittedly I'm not familiar with torch-mlir. We could potentially make it into a generic function as well if we want to support more reduce operators.

roberteg16
roberteg16 approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@roberteg16 roberteg16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanx

@ehsan-toosi ehsan-toosi merged commit 9c4ed9d into feature/fused-ops Sep 20, 2024
2 checks passed
@ehsan-toosi ehsan-toosi deleted the enadjara.xten_nn_reduce_mean_to_torch branch September 20, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberteg16 roberteg16 roberteg16 approved these changes

@p-lanza p-lanza p-lanza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehsan-toosi @roberteg16 @p-lanza