Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update llvm #1636

Merged
merged 4 commits into from
Jul 26, 2024
Merged

update llvm #1636

merged 4 commits into from
Jul 26, 2024

Conversation

fifield
Copy link
Collaborator

@fifield fifield commented Jul 23, 2024

update llvm to db1d8813

@fifield
Copy link
Collaborator Author

fifield commented Jul 23, 2024

There are some issues with vector dialect in this update, possibly related to llvm/llvm-project#97049.

example:

/home/runner/work/mlir-aie/mlir-aie/test/aievec/conv2d_msc_uij_i32_noinit.mlir:105:15: error: CHECK-NEXT: expected string not found in input
//CHECK-NEXT: vector.transfer_write %20, %arg2[%arg3, %arg4] {in_bounds = [true]} : vector<8xi32>, memref<2046x2046xi32>
              ^
<stdin>:37:67: note: scanning from here
 %20 = aievec.srs %19, %c0_i32 : vector<8xi80>, i32, vector<8xi32>
                                                                  ^
<stdin>:38:2: note: possible intended match here
 vector.transfer_write %20, %arg2[%arg3, %arg4] : vector<8xi32>, memref<2046x2046xi32>
 ^

@jsetoain @jamestcl-amd maybe you have some insights?

Copy link
Collaborator

@jsetoain jsetoain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jsetoain
Copy link
Collaborator

I've updated all aievec tests that needed updating, plus removed the ones that require fixing the deprecated pass. There are a couple of integration tests (for TOSA) that require fixing as well, I'll work on those next.

Copy link
Contributor

Coverage Report

Created: 2024-07-25 16:30

Click here for information about interpreting this report.

FilenameFunction CoverageLine CoverageRegion CoverageBranch Coverage
home/runner/work/mlir-aie/mlir-aie/lib/Dialect/AIEVec/Transforms/VectorToVectorConversions.cpp 94.74% 87.98% 86.67% 69.48%
Totals 94.74% 87.98% 86.67% 69.48%
Generated by llvm-cov -- llvm version 14.0.0

@fifield
Copy link
Collaborator Author

fifield commented Jul 25, 2024

Is passing CI but has the following tosa test failures as noted above:

Failed Tests (3):
  AIE :: Integration/Dialect/TOSA/i8xi8_mul_elem_16x1024_broadcast_1/i8xi8_mul_elem_2d_broadcast_1d_unit_dim.mlir
  AIE :: Integration/Dialect/TOSA/i8xi8_mul_elem_16x1024_broadcast_1/i8xi8_mul_elem_2d_broadcast_scalar.mlir
  AIE :: Integration/Dialect/TOSA/ui8_cast.mlir

@jsetoain
Copy link
Collaborator

jsetoain commented Jul 26, 2024

Is passing CI but has the following tosa test failures as noted above:

Failed Tests (3):
  AIE :: Integration/Dialect/TOSA/i8xi8_mul_elem_16x1024_broadcast_1/i8xi8_mul_elem_2d_broadcast_1d_unit_dim.mlir
  AIE :: Integration/Dialect/TOSA/i8xi8_mul_elem_16x1024_broadcast_1/i8xi8_mul_elem_2d_broadcast_scalar.mlir
  AIE :: Integration/Dialect/TOSA/ui8_cast.mlir

I see these tests have been failing for a while, and for some reason are not being run in CI (I thought this had been solved already). I'm doing a bisection to try and locate the offending change, that should give us a hint.

I'm going to go ahead and merge, since this is not breaking anything.

@jsetoain jsetoain added this pull request to the merge queue Jul 26, 2024
Merged via the queue into main with commit c6c52ea Jul 26, 2024
51 checks passed
@jsetoain jsetoain deleted the bump-llvm branch July 26, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants