Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWUTILS-903: Highlight X3 hybrid and PV variants #27

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dchadwic-xilinx
Copy link
Collaborator

As a test I used the device id of the X3 NIC. Before I merge this I wanna test on the real pair of variants. Raising the PR now because I want my methodology critiqued. I also will use this commit to add an extension to SWUTILS-833.
When highlighted the cell lights up like this.
image
image

@ibeecraft-amd
Copy link
Contributor

As mentioned in a quick chat.
It would be nice to extend the interesting value functionality to allow for custom messages. Highlighting whether it is a Hybrid or PV at a glance rather than just outputting the check that failed. I know for certain I will forget how to decode the device ID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants