Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New multirep PR initiated #496
base: develop
Are you sure you want to change the base?
New multirep PR initiated #496
Changes from 1 commit
60a477f
e5ae472
6c56fa8
63bf520
9222ccd
38fb967
9d4195e
bc6782a
78e80ed
f79b6ca
c2b932c
f8fe74e
0f22fdf
aa7a438
60b912e
d4cdd95
fbb636e
96a525e
8ab3750
92df65f
b2deb23
43ee95b
615c5e3
698e426
9408efc
9190c4f
f8b14f7
c5578b8
364ac77
fe64727
5a51d0e
9458c67
5af0008
5cd6170
d0b8091
4174725
01791a2
218f3c8
8e4775c
81104f2
18b22e3
265b854
9095417
8ad4249
e07761e
b6d2a71
43d20cd
6557de6
ce28399
1bd62aa
e895788
0942b9c
d25a08a
7145fd7
c42e20f
56e88e5
4afbd1e
7497575
4f88920
f2d4f65
f843f04
3132357
3ef97b0
17629d3
af395f4
42f13e8
7a76877
a62200b
3c8261b
a02ffe8
62bc1b6
5b7ad47
fdc50d0
a8c7c17
4ba09e7
512072a
fdfbe02
932c9e7
af1552e
7316083
8a5c93e
7940a29
983c275
23acbda
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need to incorporate
_index_representation
into the serialization of the object?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm.. not sure about that. But I guess it makes some sense to keep
_index_representation
as a hidden attribute since there are many calls to circuit component initializer and I might be missing correcting some when doing the change.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we caching this? This seems unnecessary as it's just a reordering of an already cached property i.e. duplicate information being cached