-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Milvus client health check #2214 #2272
Conversation
src/HealthChecks.Milvus/DependencyInjection/MilvusHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
@adamsitnik, Do we need more overload same as other health checks? |
@smnsht, could you add |
…uilderExtensions.cs Co-authored-by: Alireza Baloochi <[email protected]>
@Alirexaa I have to add milvus docker image to |
You can see an example below: Also for passing the functional test you need to add milvus container to the actions. AspNetCore.Diagnostics.HealthChecks/.github/workflows/healthchecks_elasticsearch_ci.yml Lines 31 to 36 in 65ab619
|
@Alirexaa |
LGTM. Thanks @smnsht |
Probably we need to add a property to version.props for this new packages |
What this PR does / why we need it:
Add health check for the Milvus client:
Which issue(s) this PR fixes:
Add Milvus client health check
Please reference the issue this PR will close: #2214
Special notes for your reviewer:
I am not sure about functional tests - for now they are skipped.
Should I add Milvus image to docker-compose?
Does this PR introduce a user-facing change?:
No
Please make sure you've completed the relevant tasks for this PR, out of the following list: