Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Milvus client health check #2214 #2272

Merged
merged 8 commits into from
Oct 26, 2024
Merged

Add Milvus client health check #2214 #2272

merged 8 commits into from
Oct 26, 2024

Conversation

smnsht
Copy link
Contributor

@smnsht smnsht commented Jul 31, 2024

What this PR does / why we need it:
Add health check for the Milvus client:

Which issue(s) this PR fixes:
Add Milvus client health check

Please reference the issue this PR will close: #2214

Special notes for your reviewer:
I am not sure about functional tests - for now they are skipped.
Should I add Milvus image to docker-compose?

Does this PR introduce a user-facing change?:
No

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [*] Code compiles correctly
  • [*] Created/updated tests
  • [*] Unit tests passing
  • [*] End-to-end tests passing
  • Extended the documentation
  • Provided sample for the feature

@Alirexaa
Copy link
Collaborator

Alirexaa commented Aug 1, 2024

@adamsitnik, Do we need more overload same as other health checks?

@Alirexaa
Copy link
Collaborator

Alirexaa commented Aug 1, 2024

@smnsht, could you add Milvus to labeler.yml and also add healthchecks_milvus.yaml same as other actions?

@smnsht
Copy link
Contributor Author

smnsht commented Aug 1, 2024

@Alirexaa
I've created 3 workflow files & updated labeler.yml

I have to add milvus docker image to healthchecks_milvus_ci.yml - not done yet. I'm checking how I can verify GitHub workflow (unfamiliar to me).

@Alirexaa
Copy link
Collaborator

Alirexaa commented Aug 1, 2024

@Alirexaa I've created 3 workflow files & updated labeler.yml

I have to add milvus docker image to healthchecks_milvus_ci.yml - not done yet. I'm checking how I can verify GitHub workflow (unfamiliar to me).

You can see an example below:
https://github.com/Xabaril/AspNetCore.Diagnostics.HealthChecks/blob/65ab619b0e5dcf27940a1a6baf13cc1ad4f79903/.github/workflows/healthchecks_elasticsearch_ci.yml

Also for passing the functional test you need to add milvus container to the actions.
example:

services:
elasticsearch:
image: docker.elastic.co/elasticsearch/elasticsearch:6.3.2
ports:
- 9300:9300
- 9201:9200

@smnsht smnsht marked this pull request as draft August 2, 2024 10:47
@smnsht smnsht marked this pull request as ready for review August 2, 2024 13:54
@smnsht
Copy link
Contributor Author

smnsht commented Aug 2, 2024

@Alirexaa
Done with GitHub workflow. Tested on my personal account - looks good.

@Alirexaa
Copy link
Collaborator

Alirexaa commented Aug 2, 2024

LGTM. Thanks @smnsht

@unaizorrilla
Copy link
Collaborator

Probably we need to add a property to version.props for this new packages

@Alirexaa Alirexaa merged commit 0fb8f9c into Xabaril:master Oct 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Milvus client health check
3 participants