Fix strict OpenIdConnect server response validation #2164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces a new parameter for the OpenIdConnect health check which allows to control the validation of the OpenId Provider response.
Specifically, with this PR users can enable/disable the validation of the
response_types_supported
parameter for Dynamic OpenID Providers. The specification states:Which issue(s) this PR fixes:
#2152
Special notes for your reviewer:
On my local machine test
be_healthy_if_idsvr_is_available
fails. I assume this is related to my local setup.Does this PR introduce a user-facing change?:
Yes, by default the Dynamic OpenID Providers-specific validation is disabled. Current users of the validation need to activate the check explicitly.
Please make sure you've completed the relevant tasks for this PR, out of the following list: