use webpack5 syntax to include woff2 in bundle #2133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@schulz3000 looks a good solution. However it seems you have to agree to the Contributor License Agreement before this PR can continue. |
|
Can this move forward? This is a pretty important breakage in .Net 8 since the icons are a core part of the UI experience. Is it allowed to re-implement this PR? |
It would be great if this could move forward. Is there a community standard around wait time for the CLA? Can someone else do the PR if no word is received on it? |
|
I think it would be wise to try re-implement this PR. I'm on it. |
3 tasks
|
closed this as completed via #2217 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes: #2130
Special notes for your reviewer:
Does this PR introduce a user-facing change?: no
Please make sure you've completed the relevant tasks for this PR, out of the following list: