Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial changes for new health checks #2106

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Editorial changes for new health checks #2106

merged 2 commits into from
Dec 4, 2023

Conversation

sungam3r
Copy link
Collaborator

@sungam3r sungam3r commented Dec 3, 2023

Unification with existing HCs.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cec0112) 67.31% compared to head (8794d32) 67.61%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2106      +/-   ##
==========================================
+ Coverage   67.31%   67.61%   +0.29%     
==========================================
  Files         270      265       -5     
  Lines        8775     8645     -130     
  Branches      634      618      -16     
==========================================
- Hits         5907     5845      -62     
+ Misses       2704     2640      -64     
+ Partials      164      160       -4     
Flag Coverage Δ
AzureBlobStorage 25.17% <100.00%> (ø)
AzureEventHubs 16.54% <100.00%> (ø)
AzureFileStorage 25.17% <100.00%> (ø)
AzureKeyVault 20.94% <100.00%> (-8.31%) ⬇️
AzureQueueStorage 25.17% <100.00%> (ø)
AzureTableStorage 26.66% <100.00%> (ø)
CosmosDb 28.10% <100.00%> (ø)
Dapr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @sungam3r !

@adamsitnik adamsitnik merged commit dfe3b26 into master Dec 4, 2023
8 checks passed
@adamsitnik adamsitnik deleted the editorial branch December 4, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants