Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SSH.NET to 2023.0.0 #2057

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Conversation

WojciechNagorski
Copy link
Contributor

Update SSH.NET to the latest version https://www.nuget.org/packages/SSH.NET/2023.0.0

New features:

  • Support for .NET 6, 7, and .NET Standard 2.0/2.1
  • Support for RSA-SHA256/512 signature algorithms
  • Support for parsing OpenSSH keys with ECDSA 256/384/521 and RSA
  • Support for SHA256 and MD5 fingerprints for host key validation
  • Added async support to SftpClient and SftpFileStream
  • Added ISftpFile interface to SftpFile
  • Removed support for old target frameworks
  • Improved performance and stability
  • Added the ability to set the last write and access time for Sftp files

@WojciechNagorski
Copy link
Contributor Author

@unaizorrilla @adamsitnik Could you do a review? This issue is important because the previous version did not support modern .NET add all. The lack of RSA-SHA256 is also a huge problem. For example, the default Azure settings make it impossible to use the AspNetCore.HealthChecks.Network library. Users must enable deprecated algorithms in the SSH configuration on the server.

Copy link
Collaborator

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @WojciechNagorski !

Thank you for providing an update.

Please also bump the version from 7.0.0 to 7.1.0 here:

<HealthCheckNetwork>7.0.0</HealthCheckNetwork>

Copy link
Collaborator

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adamsitnik adamsitnik merged commit 2824b09 into Xabaril:master Oct 16, 2023
2 checks passed
@WojciechNagorski WojciechNagorski deleted the new-sshnet branch October 16, 2023 10:05
@WojciechNagorski
Copy link
Contributor Author

Thanks a lot @adamsitnik !

@unaizorrilla
Copy link
Collaborator

Thanks @WojciechNagorski for your contrib!

@sungam3r sungam3r added the dependencies Pull requests that update a dependency file label Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file network
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants