Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split Azure packages into dedicated nuget packages #2038

Merged
merged 14 commits into from
Sep 19, 2023

Conversation

adamsitnik
Copy link
Collaborator

@adamsitnik adamsitnik commented Sep 14, 2023

This PR contains following changes::

  • split HealthChecks.AzureStorage into Storage, Files and Queues packages
  • remove HealthChecks.AzureStorage
  • move Azure Tables health check from HealthChecks.CosmosDb to dedicated package
  • move Azure Event Hubs health check from HealthChecks.AzureServiceBus to dedicated package
  • enforce Azure health checks: How to steer the users towards best practices #2040
  • add missing README.md

What is not included in this PR (I'll send a separate PR after this gets merged):

  • sign new assemblies
  • update to 8.0 microsoft extensions

fixes #2040
fixes #1371 (health check reuse registered clients rather than creating new onesS)
fixes #1567 (client instance is created lazily when needed for the first time)
fixes #665 (two health checks were using the same name)

@github-actions github-actions bot added github_actions Pull requests that update Github_actions code azure cosmosdb labels Sep 14, 2023
@unaizorrilla
Copy link
Collaborator

Hi @adamsitnik

The idea is mantain the AzureStorage package with 3 references to Tables, Queues and Shares? Why not deprecated current Storage and move the IHealthCheckBuilder extensiosn to each package?

@codecov-commenter
Copy link

Codecov Report

Merging #2038 (b9ebfc4) into master (7060bdd) will decrease coverage by 2.17%.
The diff coverage is 97.87%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master    #2038      +/-   ##
==========================================
- Coverage   69.06%   66.90%   -2.17%     
==========================================
  Files         179      264      +85     
  Lines        4613     8641    +4028     
  Branches      447      620     +173     
==========================================
+ Hits         3186     5781    +2595     
- Misses       1323     2700    +1377     
- Partials      104      160      +56     
Flag Coverage Δ
ApplicationStatus 26.66% <ø> (ø)
ArangoDb 26.50% <ø> (ø)
Aws.S3 14.28% <ø> (ø)
Aws.SecretsManager 14.54% <ø> (ø)
Aws.Sns 14.77% <ø> (ø)
Aws.Sqs 15.28% <ø> (ø)
Aws.SystemsManager 14.54% <ø> (ø)
Azure.IoTHub 12.82% <ø> (ø)
AzureApplicationInsights 14.70% <ø> (ø)
AzureBlobStorage 25.17% <96.96%> (?)
AzureDigitalTwin 35.76% <ø> (ø)
AzureEventHubs 16.54% <90.00%> (?)
AzureKeyVault 29.24% <100.00%> (+3.55%) ⬆️
AzureQueueStorage 25.17% <96.96%> (?)
AzureSearch 16.10% <ø> (ø)
AzureServiceBus 71.34% <98.67%> (-1.66%) ⬇️
Consul 22.58% <ø> (ø)
CosmosDb 28.10% <96.87%> (-30.28%) ⬇️
Dapr 14.50% <ø> (?)
DocumentDb 14.64% <ø> (ø)
DynamoDb 12.12% <ø> (ø)
Elasticsearch 39.49% <ø> (ø)
EventStore 62.08% <ø> (ø)
EventStore.gRPC 25.51% <ø> (ø)
Gcp.CloudFirestore 12.10% <ø> (ø)
Gremlin 23.07% <ø> (ø)
Hangfire 10.97% <ø> (ø)
IbmMQ 30.76% <ø> (ø)
InfluxDB 15.00% <ø> (ø)
Kafka 22.03% <ø> (ø)
Kubernetes 41.54% <ø> (ø)
MongoDb 28.86% <ø> (ø)
MySql 33.33% <ø> (ø)
Nats 68.20% <ø> (ø)
Npgsql 28.73% <ø> (ø)
OpenIdConnectServer 39.28% <ø> (ø)
Oracle 60.60% <ø> (ø)
Prometheus.Metrics 29.80% <ø> (ø)
Publisher.ApplicationInsights 14.76% <ø> (ø)
Publisher.CloudWatch 19.02% <ø> (ø)
Publisher.Datadog 15.00% <ø> (ø)
Publisher.Prometheus 18.75% <ø> (ø)
Publisher.Seq 40.30% <ø> (ø)
RabbitMQ 47.89% <ø> (ø)
RavenDb 70.74% <ø> (ø)
Redis 65.71% <ø> (-0.63%) ⬇️
SendGrid 11.92% <ø> (ø)
SignalR 24.22% <ø> (ø)
Sqlite 26.38% <ø> (ø)
System 37.28% <ø> (ø)
Uris 61.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
....Secrets/AzureKeyVaultSecretsHealthCheckOptions.cs 75.00% <ø> (ø)
...torage.Blobs/AzureBlobStorageHealthCheckOptions.cs 100.00% <ø> (ø)
...rage.Queues/AzureQueueStorageHealthCheckOptions.cs 100.00% <ø> (ø)
src/HealthChecks.AzureServiceBus/ClientCache.cs 19.04% <ø> (ø)
...Checks.CosmosDb/AzureCosmosDbHealthCheckOptions.cs 100.00% <ø> (ø)
...yInjection/CosmosDbHealthCheckBuilderExtensions.cs 90.00% <75.00%> (-5.78%) ⬇️
...tion/AzureEventHubHealthChecksBuilderExtensions.cs 87.50% <87.50%> (ø)
...n/AzureBlobStorageHealthChecksBuilderExtensions.cs 90.00% <90.00%> (ø)
.../AzureQueueStorageHealthChecksBuilderExtensions.cs 90.00% <90.00%> (ø)
...re.Messaging.EventHubs/AzureEventHubHealthCheck.cs 91.66% <91.66%> (ø)
... and 11 more

... and 89 files with indirect coverage changes

@adamsitnik
Copy link
Collaborator Author

@unaizorrilla the PR is ready for review, PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure cosmosdb github_actions Pull requests that update Github_actions code
Projects
None yet
3 participants