Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nats] Add overload for NatsOptions with IServiceProvider #2024

Merged
merged 2 commits into from
Dec 3, 2023

Conversation

cieciurm
Copy link
Contributor

@cieciurm cieciurm commented Sep 4, 2023

What this PR does / why we need it:

This PR adds a new overload for Nats Health Check supporting NatsOptions creation with IServiceProvider.

Which issue(s) this PR fixes:

#1827

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing
  • End-to-end tests passing
  • Extended the documentation
  • Provided sample for the feature

@github-actions github-actions bot added the nats label Sep 4, 2023
@cieciurm cieciurm changed the title Nats :: Add overload for NatsOptions with IServiceProvider [Nats] Add overload for NatsOptions with IServiceProvider Sep 6, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c000704) 69.24% compared to head (9ddd3b7) 69.32%.
Report is 18 commits behind head on master.

Files Patch % Lines
...dencyInjection/NatsHealthCheckBuilderExtensions.cs 92.85% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2024      +/-   ##
==========================================
+ Coverage   69.24%   69.32%   +0.07%     
==========================================
  Files         176      176              
  Lines        4582     4596      +14     
  Branches      445      447       +2     
==========================================
+ Hits         3173     3186      +13     
  Misses       1305     1305              
- Partials      104      105       +1     
Flag Coverage Δ
Nats 69.85% <92.85%> (+1.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sungam3r sungam3r merged commit f9d4cc9 into Xabaril:master Dec 3, 2023
2 checks passed
@sungam3r
Copy link
Collaborator

sungam3r commented Dec 3, 2023

@cieciurm Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants