Remove StringComparison.OrdinalIgnoreCase as EF Core translation #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ranslate to SQL code.
|
@dotnet-policy-service agree |
sungam3r
reviewed
Aug 15, 2023
src/HealthChecks.UI/Core/HostedService/HealthCheckReportCollector.cs
Outdated
Show resolved
Hide resolved
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1995 +/- ##
==========================================
+ Coverage 66.19% 66.31% +0.12%
==========================================
Files 253 251 -2
Lines 8726 8701 -25
Branches 627 623 -4
==========================================
- Hits 5776 5770 -6
+ Misses 2785 2769 -16
+ Partials 165 162 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
hey @sungam3r , when is the next nuget release planned? |
|
I was away from this repo for 4 months. Since my last commits many things happened. I think we will publish v8 release next month or two. ping @adamsitnik @unaizorrilla |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix EF Core translation to SQL code
Which issue(s) this PR fixes:
Remove StringComparison.OrdinalIgnoreCase as EF Core is not able to translate to SQL code string.Equals with StringComparison
Special notes for your reviewer:
It fails in at least two EF Core providers I've tested SQLServer and SQLite
Does this PR introduce a user-facing change?:
NO
Please make sure you've completed the relevant tasks for this PR, out of the following list: