Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DocumentDb - Add option to check database and collection #1985

Merged
merged 9 commits into from
Aug 7, 2023

Conversation

cieciurm
Copy link
Contributor

@cieciurm cieciurm commented Aug 5, 2023

What this PR does / why we need it:

  • Extends DocumentDb Health Check with option to check against provided database and collection
  • When both provided then Health Check calls ReadDocumentCollectionAsync(...)

Which issue(s) this PR fixes:
closes #333

Special notes for your reviewer:

  • Registration test added

Does this PR introduce a user-facing change?: No.

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing
  • End-to-end tests passing
  • Extended the documentation
  • Provided sample for the feature

@sungam3r sungam3r added the enhancement New feature or request label Aug 6, 2023
@cieciurm
Copy link
Contributor Author

cieciurm commented Aug 7, 2023

Changes applied, thanks for the review

cc: @sungam3r

@cieciurm
Copy link
Contributor Author

cieciurm commented Aug 7, 2023

Updated, ready now.

cc: @sungam3r

@codecov-commenter
Copy link

Codecov Report

Merging #1985 (8ee009a) into master (1a9df92) will decrease coverage by 0.22%.
Report is 2 commits behind head on master.
The diff coverage is 31.25%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1985      +/-   ##
==========================================
- Coverage   66.33%   66.11%   -0.22%     
==========================================
  Files         253      251       -2     
  Lines        8717     8720       +3     
  Branches      626      625       -1     
==========================================
- Hits         5782     5765      -17     
- Misses       2772     2793      +21     
+ Partials      163      162       -1     
Flag Coverage Δ
Dapr ?
DocumentDb 14.64% <31.25%> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...c/HealthChecks.DocumentDb/DocumentDbHealthCheck.cs 20.00% <21.42%> (-5.00%) ⬇️
src/HealthChecks.DocumentDb/DocumentDbOptions.cs 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@sungam3r sungam3r merged commit 0f6818a into Xabaril:master Aug 7, 2023
2 checks passed
@sungam3r
Copy link
Collaborator

sungam3r commented Aug 7, 2023

Thanks.

@sungam3r sungam3r added this to the V 7.1 milestone Aug 7, 2023
@cieciurm cieciurm deleted the documentdb_hc branch August 7, 2023 07:11
@cieciurm
Copy link
Contributor Author

cieciurm commented Aug 7, 2023

Thanks @sungam3r for review and explanations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentdb enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CosmosDB health check is healthy whilst the write calls timeout
3 participants