-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DocumentDb - Add option to check database and collection #1985
Conversation
test/HealthChecks.DocumentDb.Tests/HealthChecks.DocumentDb.approved.txt
Outdated
Show resolved
Hide resolved
Co-authored-by: Ivan Maximov <[email protected]>
…roved.txt Co-authored-by: Ivan Maximov <[email protected]>
Co-authored-by: Ivan Maximov <[email protected]>
Co-authored-by: Ivan Maximov <[email protected]>
Co-authored-by: Ivan Maximov <[email protected]>
Changes applied, thanks for the review cc: @sungam3r |
Updated, ready now. cc: @sungam3r |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1985 +/- ##
==========================================
- Coverage 66.33% 66.11% -0.22%
==========================================
Files 253 251 -2
Lines 8717 8720 +3
Branches 626 625 -1
==========================================
- Hits 5782 5765 -17
- Misses 2772 2793 +21
+ Partials 163 162 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Thanks. |
Thanks @sungam3r for review and explanations! |
What this PR does / why we need it:
ReadDocumentCollectionAsync(...)
Which issue(s) this PR fixes:
closes #333
Special notes for your reviewer:
Does this PR introduce a user-facing change?: No.
Please make sure you've completed the relevant tasks for this PR, out of the following list: