UIResponseWriter - Do not encode non-ASCII characters #1984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cieciurm
changed the title
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1984 +/- ##
==========================================
+ Coverage 66.33% 66.35% +0.02%
==========================================
Files 253 251 -2
Lines 8717 8693 -24
Branches 626 622 -4
==========================================
- Hits 5782 5768 -14
+ Misses 2772 2763 -9
+ Partials 163 162 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sungam3r
reviewed
Aug 6, 2023
| @@ -55,6 +57,7 @@ private static JsonSerializerOptions CreateJsonOptions() | |||
| { | |||
| AllowTrailingCommas = true, | |||
| PropertyNamingPolicy = JsonNamingPolicy.CamelCase, | |||
| Encoder = JavaScriptEncoder.Create(UnicodeRanges.All), | |||
There was a problem hiding this comment.
🤔 Could be potentially breaking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
你好 => \u4F60\u597DWhich issue(s) this PR fixes: #1557
Special notes for your reviewer:
Does this PR introduce a user-facing change?: No.
Please make sure you've completed the relevant tasks for this PR, out of the following list: