Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message #1962

Merged
merged 1 commit into from
Jul 30, 2023
Merged

Fix error message #1962

merged 1 commit into from
Jul 30, 2023

Conversation

sungam3r
Copy link
Collaborator

fixes #1367

@github-actions github-actions bot added the UI label Jul 30, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1962 (2426e6a) into master (9ed4092) will decrease coverage by 0.14%.
Report is 1 commits behind head on master.
The diff coverage is 33.33%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1962      +/-   ##
==========================================
- Coverage   66.27%   66.13%   -0.14%     
==========================================
  Files         250      250              
  Lines        8653     8653              
  Branches      618      618              
==========================================
- Hits         5735     5723      -12     
- Misses       2762     2772      +10     
- Partials      156      158       +2     
Flag Coverage Δ
UI 65.49% <33.33%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../Discovery/K8S/KubernetesDiscoveryHostedService.cs 27.48% <0.00%> (ø)
...ks.UI/Core/Notifications/WebHookFailureNotifier.cs 46.95% <0.00%> (ø)
...I/Core/Discovery/K8S/KubernetesDiscoveryOptions.cs 80.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@sungam3r sungam3r merged commit ad669d3 into master Jul 30, 2023
3 checks passed
@sungam3r sungam3r deleted the msg branch July 30, 2023 06:22
@sungam3r sungam3r mentioned this pull request Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a bug when LogError
2 participants