Fixes some build issues #1952
Closed
Fixes some build issues #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1952 +/- ##
==========================================
- Coverage 66.39% 66.32% -0.07%
==========================================
Files 250 250
Lines 8644 8644
Branches 614 614
==========================================
- Hits 5739 5733 -6
- Misses 2752 2756 +4
- Partials 153 155 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
What issues? |
sungam3r
reviewed
Jul 24, 2023
| @@ -5,23 +5,21 @@ namespace HealthChecks.UI.Data | |||
| { | |||
| public class HealthChecksDb : DbContext | |||
| { | |||
| public DbSet<HealthCheckConfiguration> Configurations { get; set; } | |||
| public DbSet<HealthCheckConfiguration> Configurations => Set<HealthCheckConfiguration>(); | |||
There was a problem hiding this comment.
Never mind, false positive. I will close the PR
I have removed the pragma warning for CS8618 and made use of Set to prevent CS8618 according https://learn.microsoft.com/en-us/ef/core/miscellaneous/nullable-reference-types#dbcontext-and-dbset |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some build issues