Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive PR: Add HealthChecks.Dapr #1947

Merged
merged 27 commits into from
Jul 25, 2023
Merged

Conversation

cieciurm
Copy link
Contributor

@cieciurm cieciurm commented Jul 22, 2023

What this PR does / why we need it:

This PR revives #846

Which issue(s) this PR fixes:

#712

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing
  • End-to-end tests passing
  • Extended the documentation
  • Provided sample for the feature

@github-actions github-actions bot added the documentation An issue or pull request regarding documentation improvements label Jul 22, 2023
@cieciurm cieciurm force-pushed the feature/dapr branch 7 times, most recently from 5c9be0b to e806aa5 Compare July 22, 2023 17:37
@cieciurm cieciurm changed the title Revive PR: HealthChecks.Dapr [work in progress] Revive PR: HealthChecks.Dapr Jul 22, 2023
@cieciurm cieciurm changed the title [work in progress] Revive PR: HealthChecks.Dapr Revive PR: HealthChecks.Dapr Jul 23, 2023
@cieciurm cieciurm marked this pull request as ready for review July 23, 2023 07:19
@cieciurm cieciurm changed the title Revive PR: HealthChecks.Dapr Revive PR: Add HealthChecks.Dapr Jul 24, 2023
@sungam3r sungam3r added the dapr label Jul 25, 2023
@sungam3r sungam3r linked an issue Jul 25, 2023 that may be closed by this pull request
@sungam3r sungam3r merged commit cb0871a into Xabaril:master Jul 25, 2023
2 checks passed
@sungam3r
Copy link
Collaborator

Thanks @cieciurm !

@cieciurm cieciurm deleted the feature/dapr branch July 28, 2023 15:03
@sungam3r sungam3r mentioned this pull request Jul 30, 2023
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 76.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 66.49%. Comparing base (3956b01) to head (998da30).
Report is 123 commits behind head on master.

Files with missing lines Patch % Lines
src/HealthChecks.Dapr/DaprHealthCheck.cs 33.33% 5 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1947      +/-   ##
==========================================
+ Coverage   66.46%   66.49%   +0.02%     
==========================================
  Files         250      252       +2     
  Lines        8627     8652      +25     
  Branches      610      614       +4     
==========================================
+ Hits         5734     5753      +19     
- Misses       2741     2746       +5     
- Partials      152      153       +1     
Flag Coverage Δ
Dapr 14.61% <76.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dapr documentation An issue or pull request regarding documentation improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide Dapr health check
4 participants