-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revive PR: Add HealthChecks.Dapr #1947
Conversation
5c9be0b
to
e806aa5
Compare
src/HealthChecks.Dapr/DependencyInjection/DaprHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/HealthChecks.Dapr/DependencyInjection/DaprHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
test/HealthChecks.Dapr.Tests/DependencyInjection/DaprRegistrationTests.cs
Outdated
Show resolved
Hide resolved
test/HealthChecks.Dapr.Tests/DependencyInjection/DaprRegistrationTests.cs
Outdated
Show resolved
Hide resolved
test/HealthChecks.Dapr.Tests/DependencyInjection/DaprRegistrationTests.cs
Outdated
Show resolved
Hide resolved
Thanks @cieciurm ! |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1947 +/- ##
==========================================
+ Coverage 66.46% 66.49% +0.02%
==========================================
Files 250 252 +2
Lines 8627 8652 +25
Branches 610 614 +4
==========================================
+ Hits 5734 5753 +19
- Misses 2741 2746 +5
- Partials 152 153 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
What this PR does / why we need it:
This PR revives #846
Which issue(s) this PR fixes:
#712
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Please make sure you've completed the relevant tasks for this PR, out of the following list: