Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IHealthCheckReportCollector public and fix approval tests for UI projects #1787

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

sungam3r
Copy link
Collaborator

@sungam3r sungam3r commented Apr 4, 2023

fixes #1779

@github-actions github-actions bot added the UI label Apr 4, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1787 (1e1d231) into master (6de1ec2) will decrease coverage by 0.44%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #1787      +/-   ##
==========================================
- Coverage   66.26%   65.82%   -0.44%     
==========================================
  Files         145      153       +8     
  Lines        3910     4053     +143     
  Branches      388      399      +11     
==========================================
+ Hits         2591     2668      +77     
- Misses       1230     1295      +65     
- Partials       89       90       +1     
Flag Coverage Δ
ApplicationStatus 26.84% <ø> (ø)
ArangoDb 26.66% <ø> (ø)
Aws.S3 14.37% <ø> (ø)
Aws.SecretsManager 14.63% <ø> (?)
Aws.Sns 14.68% <ø> (ø)
Aws.Sqs 15.38% <ø> (ø)
Aws.SystemsManager 14.63% <ø> (?)
Azure.IoTHub 12.88% <ø> (ø)
AzureDigitalTwin 35.40% <ø> (ø)
AzureKeyVault 19.53% <ø> (ø)
AzureServiceBus 56.14% <ø> (ø)
AzureStorage 56.86% <ø> (ø)
Consul 22.72% <ø> (ø)
CosmosDb 58.53% <ø> (ø)
DocumentDb 14.18% <ø> (ø)
DynamoDb 14.00% <ø> (ø)
Elasticsearch 18.56% <ø> (ø)
EventStore 61.87% <ø> (ø)
EventStore.gRPC 25.69% <ø> (ø)
Gcp.CloudFirestore 12.17% <ø> (ø)
Gremlin 23.23% <ø> (ø)
Hangfire 11.04% <ø> (ø)
IbmMQ 30.96% <ø> (ø)
InfluxDB 13.40% <ø> (ø)
Kafka 22.15% <ø> (ø)
MongoDb 31.63% <ø> (ø)
MySql 18.51% <ø> (ø)
Nats 67.52% <ø> (ø)
Npgsql 28.14% <ø> (ø)
OpenIdConnectServer 25.16% <ø> (?)
Oracle 59.62% <ø> (ø)
Prometheus.Metrics 30.00% <ø> (ø)
Publisher.ApplicationInsights 10.37% <ø> (ø)
Publisher.CloudWatch 19.12% <ø> (ø)
Publisher.Datadog 15.09% <ø> (ø)
Publisher.Prometheus 19.27% <ø> (ø)
Publisher.Seq 39.37% <ø> (ø)
RabbitMQ 48.59% <ø> (ø)
RavenDb 69.40% <ø> (ø)
Redis 60.54% <ø> (ø)
SendGrid 12.00% <ø> (ø)
SignalR 28.28% <ø> (ø)
SqlServer 28.74% <ø> (ø)
Sqlite 26.54% <ø> (ø)
System 37.39% <ø> (ø)
Uris 61.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sungam3r sungam3r merged commit 2119abe into master Apr 5, 2023
@sungam3r sungam3r deleted the public branch April 5, 2023 08:49
@sungam3r sungam3r mentioned this pull request Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HealthCheckReportCollector fails GetHealthReportAsync on Azure
2 participants