Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor fixes #2492

Merged
merged 5 commits into from
Oct 4, 2023
Merged

fix: minor fixes #2492

merged 5 commits into from
Oct 4, 2023

Conversation

mvadari
Copy link
Collaborator

@mvadari mvadari commented Sep 28, 2023

High Level Overview of Change

This PR moves createValidateTests.js to xrpl/tools instead of being in the top-level tools folder, and fixes an isString import (changes it from lodash to the in-package version).

Context of Change

Discovered when working on #2491

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Did you update HISTORY.md?

  • No, this change does not impact library users

Test Plan

N/A

Copy link
Contributor

@JST5000 JST5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ckniffen ckniffen merged commit e51526a into main Oct 4, 2023
17 checks passed
@ckniffen ckniffen deleted the minor-fixes branch October 4, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants