more cleanup

XRPLF · Oct 23, 2023 · f129354 · f129354
1 parent 915d588
commit f129354
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 35 deletions.
diff --git a/packages/xrpl/src/models/transactions/XChainAccountCreateCommit.ts b/packages/xrpl/src/models/transactions/XChainAccountCreateCommit.ts
@@ -3,7 +3,6 @@ import { Amount, XChainBridge } from '../common'
 import {
   BaseTransaction,
   isAmount,
-  isString,
   isXChainBridge,
   validateBaseTransaction,
   validateRequiredField,

diff --git a/packages/xrpl/test/models/XChainModifyBridge.test.ts b/packages/xrpl/test/models/XChainModifyBridge.test.ts
@@ -13,88 +13,88 @@ describe('XChainModifyBridge', function () {
 
   beforeEach(function () {
     tx = {
-  "Account": "rHb9CJAWyB4rj91VRWn96DkukG4bwdtyTh",
-  "XChainBridge": {
-    "LockingChainDoor": "rGzx83BVoqTYbGn7tiVAnFw7cbxjin13jL",
-    "LockingChainIssue": {
-      "currency": "XRP"
-    },
-    "IssuingChainDoor": "r3kmLJN5D28dHuH8vZNUZpMC43pEHpaocV",
-    "IssuingChainIssue": {
-      "currency": "XRP"
-    }
-  },
-  "Fee": "10",
-  "Flags": 0,
-  "MinAccountCreateAmount": "10000",
-  "Sequence": 1,
-  "SignatureReward": "1000",
-  "TransactionType": "XChainModifyBridge"
-} as any
+      Account: 'rHb9CJAWyB4rj91VRWn96DkukG4bwdtyTh',
+      XChainBridge: {
+        LockingChainDoor: 'rGzx83BVoqTYbGn7tiVAnFw7cbxjin13jL',
+        LockingChainIssue: {
+          currency: 'XRP',
+        },
+        IssuingChainDoor: 'r3kmLJN5D28dHuH8vZNUZpMC43pEHpaocV',
+        IssuingChainIssue: {
+          currency: 'XRP',
+        },
+      },
+      Fee: '10',
+      Flags: 0,
+      MinAccountCreateAmount: '10000',
+      Sequence: 1,
+      SignatureReward: '1000',
+      TransactionType: 'XChainModifyBridge',
+    } as any
   })
 
   it('verifies valid XChainModifyBridge', function () {
     assert.doesNotThrow(() => validateXChainModifyBridge(tx))
     assert.doesNotThrow(() => validate(tx))
   })
 
-  it('throws w/ invalid MinAccountCreateAmount', function () {
-    tx.MinAccountCreateAmount = {"currency":"ETH"}
+  it('throws w/ missing XChainBridge', function () {
+    delete tx.XChainBridge
 
     assert.throws(
       () => validateXChainModifyBridge(tx),
       ValidationError,
-      'XChainModifyBridge: invalid field MinAccountCreateAmount',
+      'XChainModifyBridge: missing field XChainBridge',
     )
     assert.throws(
       () => validate(tx),
       ValidationError,
-      'XChainModifyBridge: invalid field MinAccountCreateAmount',
+      'XChainModifyBridge: missing field XChainBridge',
     )
   })
 
-  it('throws w/ invalid SignatureReward', function () {
-    tx.SignatureReward = {"currency":"ETH"}
+  it('throws w/ invalid XChainBridge', function () {
+    tx.XChainBridge = { XChainDoor: 'test' }
 
     assert.throws(
       () => validateXChainModifyBridge(tx),
       ValidationError,
-      'XChainModifyBridge: invalid field SignatureReward',
+      'XChainModifyBridge: invalid field XChainBridge',
     )
     assert.throws(
       () => validate(tx),
       ValidationError,
-      'XChainModifyBridge: invalid field SignatureReward',
+      'XChainModifyBridge: invalid field XChainBridge',
     )
   })
 
-  it("throws w/ missing XChainBridge", function () {
-    delete tx.XChainBridge
+  it('throws w/ invalid SignatureReward', function () {
+    tx.SignatureReward = { currency: 'ETH' }
 
     assert.throws(
       () => validateXChainModifyBridge(tx),
       ValidationError,
-      'XChainModifyBridge: missing field XChainBridge',
+      'XChainModifyBridge: invalid field SignatureReward',
     )
     assert.throws(
       () => validate(tx),
       ValidationError,
-      'XChainModifyBridge: missing field XChainBridge',
+      'XChainModifyBridge: invalid field SignatureReward',
     )
   })
 
-  it('throws w/ invalid XChainBridge', function () {
-    tx.XChainBridge = {"XChainDoor":"test"}
+  it('throws w/ invalid MinAccountCreateAmount', function () {
+    tx.MinAccountCreateAmount = { currency: 'ETH' }
 
     assert.throws(
       () => validateXChainModifyBridge(tx),
       ValidationError,
-      'XChainModifyBridge: invalid field XChainBridge',
+      'XChainModifyBridge: invalid field MinAccountCreateAmount',
     )
     assert.throws(
       () => validate(tx),
       ValidationError,
-      'XChainModifyBridge: invalid field XChainBridge',
+      'XChainModifyBridge: invalid field MinAccountCreateAmount',
     )
   })
 })