Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JA] Follow-up of amendments update #2083

Merged
merged 2 commits into from
Aug 25, 2023
Merged

[JA] Follow-up of amendments update #2083

merged 2 commits into from
Aug 25, 2023

Conversation

tequdev
Copy link
Contributor

@tequdev tequdev commented Aug 23, 2023 •
edited
Loading

@tequdev tequdev force-pushed the ja-amendments branch 3 times, most recently from 66bf9ae to 2df5ccf Compare August 23, 2023 08:31
mDuo13
mDuo13 approved these changes Aug 23, 2023
View reviewed changes
Copy link
Collaborator

@mDuo13 mDuo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I only saw some minor things worth mentioning.

content/concepts/consensus-network/amendments/amendments.ja.md Outdated Show resolved Hide resolved
content/concepts/consensus-network/amendments/known-amendments.ja.md Outdated Show resolved Hide resolved
@mDuo13 mDuo13 merged commit 64d99c6 into XRPLF:master Aug 25, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mDuo13 mDuo13 mDuo13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tequdev @mDuo13